notmuch, branch 0.32_rc0

debian: update d/libnotmuch5

2021-04-24T11:55:45Z

This corresponds to libnotmuch 5.3. It should be backward compatible because it only adds symbols.

debian: start changelog for 0.32~rc0-1

2021-04-24T11:49:44Z

update version to 0.32~rc0

2021-04-24T11:45:54Z

compat: rename {,notmuch_}canonicalize_file_name

2021-04-24T11:07:00Z

When compat canonicalize_file_name was introduced, it was limited to C code only because it was used by C code only during that time. >From 5ec6fd4d, (lib/open: check for split configuration when creating database., 2021-02-16), lib/open.cc, which is C++, relies on the existent of canonicalize_file_name. However, we can't blindly enable canonicalize_file_name for C++ code, because different implementation has different additional signature for C++ and users can arbitrarily add -DHAVE_CANONICALIZE_FILE_NAME=0 to {C,CXX}FLAGS. Let's move our implementation into a util library. Helped-by: Tomi Ollila Signed-off-by: Đoàn Trần Công Danh

ruby: fix ruby 3.1 warnings

2021-04-19T00:42:43Z

init.c:214:5: warning: ‘rb_cData’ is deprecated: by: rb_cObject. Will be removed in 3.1. [-Wdeprecated-declarations] Signed-off-by: Felipe Contreras

lib/n_d_index_file: check return value from _n_m_add_filename

2021-04-18T13:02:20Z

Ignoring this return value seems like a bad idea in general, and in particular it has been hiding one or more bugs related to handling long directory names.

test-lib: unset XDG_CONFIG_HOME

2021-04-18T13:00:10Z

lib/open.cc:_load_key_file will only open xdg-config files in $XDG_CONFIG_HOME if it's defined, $HOME/.config will be considered if and only if XDG_CONFIG_HOME not defined. Let's unset said variable before running the test.

lib: directly traverse postlists in _n_message_delete

2021-04-18T12:50:36Z

This is intended to fix the slow behaviour of "notmuch new" (and possibly "notmuch reindex") when large numbers of files are deleted. The underlying issue [1] seems to be the Xapian glass backend spending a large amount of time in db.has_positions when running queries with large-ish amounts of unflushed changes. This commit removes two uses of Xapian queries [2], and replaces them with an approximation of what Xapian would do after optimizing the queries. This avoids the calls to has_positions (which are in any case un-needed because we are only using boolean terms here). [1] Thanks to "andres" on IRC for narrowing down the performance bottleneck. [2] Thanks to Olly Betts of Xapian fame for talking me a through a fix that does not require people to update Xapian.

perf-tests: add test for removing files.

2021-04-18T12:50:26Z

Without the proposed fix for deletion performance [1], this test is probably unreasonably slow compared to others at the same small/medium/large scale. [1]: id:20210414021627.1236560-3-david@tethera.net

test: put shim at end of LD_PRELOAD path

2021-04-16T12:06:39Z

Certain tools like the address-sanitizer fail if they are not the first LD_PRELOADed library. It does not seem to matter for our shims, as long as they are loaded before libnotmuch.