notmuch, branch 0.34.1thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.34.12021-11-03T13:20:49Zdebian: refinalize changelog2021-11-03T13:20:49ZDavid Bremnerdavid@tethera.net2021-11-03T13:20:49Zurn:sha1:6858c365956ba26b42721093707e5a57ca8a6b93NEWS: finalize release date2021-11-03T13:20:08ZDavid Bremnerdavid@tethera.net2021-11-03T13:20:08Zurn:sha1:ba7f26e2a5fbf7f969e778384b8a9114f872cc24debian: changelog for 0.34.1-12021-10-31T11:25:25ZDavid Bremnerdavid@tethera.net2021-10-31T11:25:25Zurn:sha1:edd5e15360d9f4df46722bc2399c9dee21429b3aNEWS: start news for 0.34.12021-10-31T11:18:38ZDavid Bremnerdavid@tethera.net2021-10-31T11:18:38Zurn:sha1:b4894de87799179386f6f6a38fd4a6f4e58b1576version: bump to 0.34.12021-10-31T11:11:25ZDavid Bremnerdavid@tethera.net2021-10-31T11:11:25Zurn:sha1:0c2edc522bbcf1f70c0173643e776b665b4af90elib/load_config: deallocate / NULL database on fatal error2021-10-30T16:51:50ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:38Zurn:sha1:fe51c275fcd7107d92b40de511086300ba4060ed
This fixes a potential memory leak, and makes the behaviour of
notmuch_database_load_config (somewhat) consistent with
n_d_{open,create} with config.
lib/load_config: document expectations for db on error, add tests2021-10-30T16:49:37ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:37Zurn:sha1:8f0b84789d4fda0182e073b68b73160c9b94a4b7
This is a bit different than n_d_{open,create}_with_config, since
there are several non-zero status codes where we do want to return a
non-NULL database structure.
lib/create: fix memory leak, ensure *database=NULL on error2021-10-30T16:47:47ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:36Zurn:sha1:2ba50b52302dce08068843e0029f9ee935a0d7f3
This code previously relied on _finish_open to free the notmuch struct
on errors (except for the case of database == NULL, which was a
potential double free). When we removed those frees from _finish_open,
we introduced a (small) memory leak.
In this commit, fix the memory leak, and harmonize the on-error
behaviour with n_d_open_with_config.
lib/create: document expectations for db on error, add tests2021-10-30T16:45:40ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:35Zurn:sha1:f3fcdd2ddac2384c0c1daeffa495ad3ec01bc1af
It seems sensible to harmonize the behaviour with
n_d_open_with_config. In this commit we just assert the desired
behaviour.
lib/open: fix potential double-free, ensure *database=NULL on error2021-10-30T16:43:58ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:34Zurn:sha1:74c4ce6d88bcc643424c5d89cc8d30cd835e46c3
During refactoring for 0.32, the code that set notmuch=NULL on various
errors was moved into _finish_open. This meant that the the code which
relied on that to set *database to NULL on error was no longer
correct. It also introduced a potential double free, since the notmuch
struct was deallocated inside _finish_open (via n_d_destroy).
In this commit we revert to "allocator frees", and leave any cleanup
to the caller of _finish_open. This allows us to get back the
behaviour of setting *database to NULL with a small change. Other
callers of _finish_open will need free notmuch on errors.