thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=archive%2Fdebian%2F0.34.3-1 2022-01-09T19:35:52Z 2022-01-09T19:35:52Z David Bremner david@tethera.net 2022-01-09T19:35:52Z urn:sha1:51c287ead807b6e3830bc5d393a7e9a89f36db86 2022-01-09T19:35:12Z David Bremner david@tethera.net 2022-01-09T19:35:12Z urn:sha1:a226b7a29b8977003081d96850a1f9e2b9a962b9 2022-01-09T19:31:03Z David Bremner david@tethera.net 2022-01-09T19:31:03Z urn:sha1:ad147c02055982df25848735fc48be3fb378dd40 2022-01-09T19:29:05Z David Bremner david@tethera.net 2022-01-09T19:29:05Z urn:sha1:9e62a0beaa3817b9534f871b896a8ec538a4f090 2022-01-09T19:16:51Z David Bremner david@tethera.net 2022-01-08T21:21:43Z urn:sha1:8b737af28bc377db3e661a5744f3b7479b7ce485 The previous (pre-0.34.2) constructor searched for a config file but only if the database path was not specified, and only to retrieve database.path. Neither of the available options (CONFIG.SEARCH or CONFIG.NONE) matches this semantics exactly, but CONFIG.SEARCH causes less breakage for people who relied on the old behaviour to set their database.path [1]. Since it also seems like the friendlier option in the long run, this commit switches to CONFIG.SEARCH as default. This requires a certain amount of updating the pytest tests, but most users will actually have a config file, unlike the test environment. [1]: id:87fsqijx7u.fsf@metapensiero.it 2022-01-08T20:29:41Z David Bremner david@tethera.net 2022-01-08T14:03:16Z urn:sha1:9e7ea628e6bddbd7345d053a3daf14af74896cc2 If we return regular Message objects, python will try to destroy them, and the underlying notmuch object, causing e.g. the crash [1]. [1]: id:87sfu6utxg.fsf@tethera.net 2022-01-08T20:29:41Z David Bremner david@tethera.net 2022-01-08T14:03:15Z urn:sha1:d9a2b900b6525874b913276af91840983d81b3f1 This reproduces the bug reported at [1]. The second test hints at the solution, making reply return OwnedMessage objects. [1]: id:87sfu6utxg.fsf@tethera.net 2021-12-29T18:12:03Z David Bremner david@tethera.net 2021-12-23T01:44:45Z urn:sha1:14c4f9441d7fe0893003a5e793e19f1e55c9f73f This will correct the current use of an undefined variable when setting LD_LIBRARY_PATH in doc/Makefile.local It is tempting to try to replace the use of test/export-dirs.sh, but this is not as simple as it looks, as NOTMUCH_BUILDDIR is used to locate sh.config, so probably cannot also sensibly be used to define it. 2021-12-29T18:11:21Z David Bremner david@tethera.net 2021-12-25T21:22:56Z urn:sha1:25e0f5e59293ce961549201fdc74f81a3cc1675c It makes perfect sense for users to want to pre-create .notmuch, e.g. to install hooks, so we should handle the case of a .notmuch directory without an actual xapian database more gracefully. 2021-12-29T18:11:10Z David Bremner david@tethera.net 2021-12-25T21:22:55Z urn:sha1:e43bad4883cf8a0c1d58d50238da599f9e170307 `notmuch new' should go ahead and create the xapian database if it is missing, even in the case where the parent .notmuch (or equivalent) directory exists.