notmuch/bindings/python-cffi/notmuch2/_database.py, branch 0.33

python/notmuch2: fix exclude tag handling

2020-12-25T15:25:25Z

A typo in Database._create_query lost the exclude_tag names during the string to utf-8 conversion. Amended by DB: fixed patch format and updated commit message.

Fix typos

2020-08-10T00:14:36Z

Support aborting the atomic context

2020-06-16T11:17:39Z

Since it is possible to use an atomic context to abort a number of changes support this usage. Because the only way to actually abort the transaction is to close the database this must also do so. Amended by db: Note the limitation requiring close is a limitation of the underlying notmuch API, which should be fixed in a future notmuch release.

Make messages returned by Thread objects owned

2020-06-16T11:02:02Z

This reverses the logic of StandaloneMessage to instead create a OwnedMessage. Only the Thread class allows retrieving messages more then once so it can explicitly create such messages. The added test fails with SIGABRT without the fix for the message re-use in threads being present.

python/notmuch2: do not destroy messages owned by a query

2020-06-16T11:02:02Z

Any messages retrieved from a query - either directly via search_messages() or indirectly via thread objects - are owned by that query. Retrieving the same message (i.e. corresponding to the same message ID / database object) several times will always yield the same C object. The caller is allowed to destroy message objects owned by a query before the query itself - which can save memory for long-lived queries. However, that message must then never be retrieved again from that query. The python-notmuch2 bindings will currently destroy every message object in Message._destroy(), which will lead to an invalid free if the same message is then retrieved again. E.g. the following python program leads to libtalloc abort()ing: import notmuch2 db = notmuch2.Database(mode = notmuch2.Database.MODE.READ_ONLY) t = next(db.threads('*')) msgs = list(zip(t.toplevel(), t.toplevel())) msgs = list(zip(t.toplevel(), t.toplevel())) Fix this issue by creating a subclass of Message, which is used for "standalone" message which have to be freed by the caller. Message class is then used only for messages descended from a query, which do not need to be freed by the caller.

python/notmuch2: add bindings for the database config strings

2020-06-16T00:50:03Z

python/notmuch2: fix typo for "destroyed"

2019-12-23T22:13:09Z

Another fix to the docstrings, this time for the English part of the docstrings, not the Python class name. No functional changes here. Signed-off-by: Daniel Kahn Gillmor

python/notmuch2: fix typo for ObjectDestroyedError

2019-12-23T22:12:51Z

There is no functional change here, just a fix to a typo in the docstrings. Signed-off-by: Daniel Kahn Gillmor

Move from _add_message to _index_file API

2019-12-03T12:12:30Z

This moves away from the deprecated notmuch_database_add_message API and instead uses the notmuch_database_index_file API. This means instroducing a class to manage the index options and bumping the library version requirement to 5.1.

Rename package to notmuch2

2019-12-03T12:12:30Z

This is based on a previous discussion on the list where this was more or less seen as the least-bad option.