notmuch/bindings/python-cffi/notmuch2/_message.py, branch 0.38.1

bindings/python-cffi: fix docstring

2022-07-05T10:34:25Z

the method Database.get_message does exist any more (if it ever did). This makes the docstring unhelpful as an example.

Merge branch 'release'

2022-01-09T13:20:56Z

python-cffi: returned OwnedMessage objects from Message.replies

2022-01-08T20:29:41Z

If we return regular Message objects, python will try to destroy them, and the underlying notmuch object, causing e.g. the crash [1]. [1]: id:87sfu6utxg.fsf@tethera.net

bindings/python-cffi: add matched property to message objects

2022-01-01T15:48:40Z

Existing users of the legacy python bindings use message.get_flags(Message.FLAG.MATCH) to determine which messages in a thread matched. Since the bindings don't provide get_flags anymore, they should provide a property analogous to the existing "excluded" property.

Fix typos

2020-08-10T00:14:36Z

Make messages returned by Thread objects owned

2020-06-16T11:02:02Z

This reverses the logic of StandaloneMessage to instead create a OwnedMessage. Only the Thread class allows retrieving messages more then once so it can explicitly create such messages. The added test fails with SIGABRT without the fix for the message re-use in threads being present.

python/notmuch2: do not destroy messages owned by a query

2020-06-16T11:02:02Z

Any messages retrieved from a query - either directly via search_messages() or indirectly via thread objects - are owned by that query. Retrieving the same message (i.e. corresponding to the same message ID / database object) several times will always yield the same C object. The caller is allowed to destroy message objects owned by a query before the query itself - which can save memory for long-lived queries. However, that message must then never be retrieved again from that query. The python-notmuch2 bindings will currently destroy every message object in Message._destroy(), which will lead to an invalid free if the same message is then retrieved again. E.g. the following python program leads to libtalloc abort()ing: import notmuch2 db = notmuch2.Database(mode = notmuch2.Database.MODE.READ_ONLY) t = next(db.threads('*')) msgs = list(zip(t.toplevel(), t.toplevel())) msgs = list(zip(t.toplevel(), t.toplevel())) Fix this issue by creating a subclass of Message, which is used for "standalone" message which have to be freed by the caller. Message class is then used only for messages descended from a query, which do not need to be freed by the caller.

python/notmuch2: fix typo for "destroyed"

2019-12-23T22:13:09Z

Another fix to the docstrings, this time for the English part of the docstrings, not the Python class name. No functional changes here. Signed-off-by: Daniel Kahn Gillmor

Rename package to notmuch2

2019-12-03T12:12:30Z

This is based on a previous discussion on the list where this was more or less seen as the least-bad option.