thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.33.1 2021-03-27T12:26:14Z 2021-03-27T12:26:14Z David Bremner david@tethera.net 2021-02-23T19:56:47Z urn:sha1:2e39ce6eb5d5e5ae2a2a4ed419190003f47e566e This will allow more precise return values from various open related functions. 2021-02-06T23:46:46Z David Bremner david@tethera.net 2021-01-03T12:50:12Z urn:sha1:55f5e87096fda96280ccc4b191393c7e59b4df57 It is desirable to distinguish between attempting to create a database that already exists, and more fatal errors like permission problems. 2021-02-06T23:43:11Z David Bremner david@tethera.net 2021-01-03T12:30:46Z urn:sha1:eea258c0c9386a5eecae48a98b552113a3584a7d This will allow client code to provide more meaningful diagnostics. In particular it will enable "notmuch new" to continue suggsting the user run "notmuch setup" to create a config after "notmuch new" is transitioned to the new configuration framework. 2021-02-06T23:37:50Z David Bremner david@tethera.net 2021-01-03T01:50:24Z urn:sha1:baf1202fbc3b27790d0ff347e29589188d5644a5 These are needed so that the later codes line up numerically. 2020-12-25T15:25:25Z Johannes Larsen mail@johslarsen.net 2020-12-25T15:21:45Z urn:sha1:f01f6405c962e27de52eb777ac3f19ee655b71ba A typo in Database._create_query lost the exclude_tag names during the string to utf-8 conversion. Amended by DB: fixed patch format and updated commit message. 2020-08-10T00:14:36Z Jonas Bernoulli jonas@bernoul.li 2020-08-08T11:49:55Z urn:sha1:6c84dee53193a78cf797b44d3febcc14488ea6b1 2020-06-16T11:17:39Z Floris Bruynooghe flub@devork.be 2020-06-14T15:23:19Z urn:sha1:776a54a0e437651abd69a03b9f7d591ea1f992cb Since it is possible to use an atomic context to abort a number of changes support this usage. Because the only way to actually abort the transaction is to close the database this must also do so. Amended by db: Note the limitation requiring close is a limitation of the underlying notmuch API, which should be fixed in a future notmuch release. 2020-06-16T11:02:02Z Floris Bruynooghe flub@devork.be 2020-06-15T20:58:50Z urn:sha1:2d895a0119b423b117d10e890c9e0eb5d2a9cdf8 This reverses the logic of StandaloneMessage to instead create a OwnedMessage. Only the Thread class allows retrieving messages more then once so it can explicitly create such messages. The added test fails with SIGABRT without the fix for the message re-use in threads being present. 2020-06-16T11:02:02Z Anton Khirnov anton@khirnov.net 2020-06-15T20:58:49Z urn:sha1:131757907907380213b32934d9e73cec942ace43 Any messages retrieved from a query - either directly via search_messages() or indirectly via thread objects - are owned by that query. Retrieving the same message (i.e. corresponding to the same message ID / database object) several times will always yield the same C object. The caller is allowed to destroy message objects owned by a query before the query itself - which can save memory for long-lived queries. However, that message must then never be retrieved again from that query. The python-notmuch2 bindings will currently destroy every message object in Message._destroy(), which will lead to an invalid free if the same message is then retrieved again. E.g. the following python program leads to libtalloc abort()ing: import notmuch2 db = notmuch2.Database(mode = notmuch2.Database.MODE.READ_ONLY) t = next(db.threads('*')) msgs = list(zip(t.toplevel(), t.toplevel())) msgs = list(zip(t.toplevel(), t.toplevel())) Fix this issue by creating a subclass of Message, which is used for "standalone" message which have to be freed by the caller. Message class is then used only for messages descended from a query, which do not need to be freed by the caller. 2020-06-16T00:50:03Z Floris Bruynooghe flub@devork.be 2020-06-15T21:55:53Z urn:sha1:1bca41698a03980b701558fb5c481ef0a340460d This fixes some minor style/pep8 things and adds tests for the new config support. Also fixes a bug where KeyError was never raised on a missing key.