thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.34.3 2022-01-09T19:16:51Z 2022-01-09T19:16:51Z David Bremner david@tethera.net 2022-01-08T21:21:43Z urn:sha1:8b737af28bc377db3e661a5744f3b7479b7ce485 The previous (pre-0.34.2) constructor searched for a config file but only if the database path was not specified, and only to retrieve database.path. Neither of the available options (CONFIG.SEARCH or CONFIG.NONE) matches this semantics exactly, but CONFIG.SEARCH causes less breakage for people who relied on the old behaviour to set their database.path [1]. Since it also seems like the friendlier option in the long run, this commit switches to CONFIG.SEARCH as default. This requires a certain amount of updating the pytest tests, but most users will actually have a config file, unlike the test environment. [1]: id:87fsqijx7u.fsf@metapensiero.it 2022-01-08T20:29:41Z David Bremner david@tethera.net 2022-01-08T14:03:16Z urn:sha1:9e7ea628e6bddbd7345d053a3daf14af74896cc2 If we return regular Message objects, python will try to destroy them, and the underlying notmuch object, causing e.g. the crash [1]. [1]: id:87sfu6utxg.fsf@tethera.net 2021-12-05T12:53:39Z Floris Bruynooghe flub@devork.be 2021-11-06T11:02:37Z urn:sha1:ca4e1d885b0d9dcdeb45ad6f2829f88dafc7949c The python exception class was incorrectly loading the error message which resulted in unprintable exception objects. 2021-12-04T12:42:31Z David Bremner david@tethera.net 2021-10-30T16:22:35Z urn:sha1:d7f95724132bf658fd151630185899737e2ed829 Since release 0.32, libnotmuch provides searching for database and configuration paths. This commit changes the python module notmuch2 to use those facilities. This fixes the bug reported in [1], along with a couple of the deprecation warnings in the python bindings. Database.default_path is deprecated, since it no longer faithfully reflects what libnotmuch is doing, and it is also no longer used in the bindings themselves. This commit choose the default of config=CONFIG.EMPTY (equivalent to passing "" to notmuch_database_open_with_config). This makes the change upward compatible API-wise (at least as far as the test suite verifies), but changing the default to CONFIG.SEARCH would probably be more convenient for bindings users. [1]: id:87h7d4wp6b.fsf@tethera.net 2021-12-04T12:36:07Z David Bremner david@tethera.net 2021-10-30T16:22:32Z urn:sha1:4b361f4d35df92bb2c679143adedf4b88288648c These generate warnings from sphinx doc, which makes it harder to debug documentation changes. They also corrupt the output. 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:15Z urn:sha1:9ae4188610dc21101fe9bdeb158854fc7c63463e This will help provide more meaningful error messages without special casing on the client side. 2021-03-27T12:26:14Z David Bremner david@tethera.net 2021-02-23T19:56:47Z urn:sha1:2e39ce6eb5d5e5ae2a2a4ed419190003f47e566e This will allow more precise return values from various open related functions. 2021-02-06T23:46:46Z David Bremner david@tethera.net 2021-01-03T12:50:12Z urn:sha1:55f5e87096fda96280ccc4b191393c7e59b4df57 It is desirable to distinguish between attempting to create a database that already exists, and more fatal errors like permission problems. 2021-02-06T23:43:11Z David Bremner david@tethera.net 2021-01-03T12:30:46Z urn:sha1:eea258c0c9386a5eecae48a98b552113a3584a7d This will allow client code to provide more meaningful diagnostics. In particular it will enable "notmuch new" to continue suggsting the user run "notmuch setup" to create a config after "notmuch new" is transitioned to the new configuration framework. 2021-02-06T23:37:50Z David Bremner david@tethera.net 2021-01-03T01:50:24Z urn:sha1:baf1202fbc3b27790d0ff347e29589188d5644a5 These are needed so that the later codes line up numerically.