notmuch/bindings/python-cffi, branch 0.30_rc2

Support aborting the atomic context

2020-06-16T11:17:39Z

Since it is possible to use an atomic context to abort a number of changes support this usage. Because the only way to actually abort the transaction is to close the database this must also do so. Amended by db: Note the limitation requiring close is a limitation of the underlying notmuch API, which should be fixed in a future notmuch release.

Make messages returned by Thread objects owned

2020-06-16T11:02:02Z

This reverses the logic of StandaloneMessage to instead create a OwnedMessage. Only the Thread class allows retrieving messages more then once so it can explicitly create such messages. The added test fails with SIGABRT without the fix for the message re-use in threads being present.

python/notmuch2: do not destroy messages owned by a query

2020-06-16T11:02:02Z

Any messages retrieved from a query - either directly via search_messages() or indirectly via thread objects - are owned by that query. Retrieving the same message (i.e. corresponding to the same message ID / database object) several times will always yield the same C object. The caller is allowed to destroy message objects owned by a query before the query itself - which can save memory for long-lived queries. However, that message must then never be retrieved again from that query. The python-notmuch2 bindings will currently destroy every message object in Message._destroy(), which will lead to an invalid free if the same message is then retrieved again. E.g. the following python program leads to libtalloc abort()ing: import notmuch2 db = notmuch2.Database(mode = notmuch2.Database.MODE.READ_ONLY) t = next(db.threads('*')) msgs = list(zip(t.toplevel(), t.toplevel())) msgs = list(zip(t.toplevel(), t.toplevel())) Fix this issue by creating a subclass of Message, which is used for "standalone" message which have to be freed by the caller. Message class is then used only for messages descended from a query, which do not need to be freed by the caller.

python config access: fix style and KeyError bug

2020-06-16T00:50:03Z

This fixes some minor style/pep8 things and adds tests for the new config support. Also fixes a bug where KeyError was never raised on a missing key.

python/notmuch2: add bindings for the database config strings

2020-06-16T00:50:03Z

Update tox.ini for python3.8 and fix pypy3.6

2020-06-15T14:25:39Z

Python 3.8 has been released for a while now, make sure we keep supporting it correctly. PyPy 3.6 wasn not configured correctly.

Add missing set methods to tagsets

2020-06-15T10:14:11Z

Even though we use collections.abc.Set which implements all these methods under their operator names, the actual named variations of these methods are shockingly missing. So let's add them manually.

Drop deprecated/unused crypto.gpg_path

2020-02-19T12:17:49Z

crypto.gpg_path was only used when we built against gmime versions before 3.0. Since we now depend on gmime 3.0.3 or later, it is meaningless. The removal of the field from the _notmuch_config struct would be an ABI change if that struct were externally exposed, but it is not, so it's safe to unilaterally remove it. Signed-off-by: Daniel Kahn Gillmor

python/notmuch2: fix typo for "destroyed"

2019-12-23T22:13:09Z

Another fix to the docstrings, this time for the English part of the docstrings, not the Python class name. No functional changes here. Signed-off-by: Daniel Kahn Gillmor

python/notmuch2: fix typo for ObjectDestroyedError

2019-12-23T22:12:51Z

There is no functional change here, just a fix to a typo in the docstrings. Signed-off-by: Daniel Kahn Gillmor