notmuch/bindings/ruby/init.c, branch debian/0.39_rc3-1

ruby: fix "undefining the allocator of T_DATA" warnings

2025-03-08T14:39:22Z

Ruby 3.2 introduced a warning when C-extensions use structs without redefining the allocation default allocation routine meant for objects. See https://bugs.ruby-lang.org/issues/18007 for details. In the Ruby bindings this happens at `Data_Wrap_Notmuch_Object` call sites, so the object types used there needed to update their allocation. This ruby code (given a database at the hardcoded path with messages matching `tag:tmp`) exercise all the ruby objects: require 'notmuch' Notmuch::Database.open File.expand_path("~/mail") do |db| db.get_directory("/tmp") db.query("tag:tmp").search_threads.each do |t| t.messages.each do |m| puts m.header("Subject") end end end Before these changes with ruby 3.2.5 and notmuch 0.38.3 it outputs: notmuch.rb:5: warning: undefining the allocator of T_DATA class Notmuch::Query notmuch.rb:5: warning: undefining the allocator of T_DATA class Notmuch::Threads notmuch.rb:5: warning: undefining the allocator of T_DATA class Notmuch::Thread notmuch.rb:6: warning: undefining the allocator of T_DATA class Notmuch::Messages notmuch.rb:6: warning: undefining the allocator of T_DATA class Notmuch::Message notmuch release 0.38.3 now available (the last line is the message I tagged with tmp), and after the changes: notmuch release 0.38.3 now available

ruby: db: reorganize initializer

2023-05-29T10:51:02Z

In order to make it more extensible. No functional changes. Signed-off-by: Felipe Contreras

ruby: remove FileNames object

2023-04-12T10:30:01Z

Not used anymore now that we return an array of strings directly. Signed-off-by: Felipe Contreras

ruby: remove Tags object

2023-04-02T22:11:10Z

Not used anymore now that we return an array of strings directly. Signed-off-by: Felipe Contreras

ruby: split database close and destroy

2021-08-02T16:49:29Z

Mirrors the C API: 7864350c (Split notmuch_database_close into two functions, 2012-04-25). Signed-off-by: Felipe Contreras

ruby: create an actual wrapper struct

2021-07-18T20:08:42Z

Currently Ruby data points directly to a notmuch object (e.g. notmuch_database_t), since we don't need any extra data that is fine. However, in the next commit we will need extra data, therefore we create a new struct notmuch_rb_object_t wrapper which contains nothing but a pointer to the current pointer (e.g. notmuch_database_t). This struct is tied to the Ruby object, and is freed when the Ruby object is freed by the garbage collector. We do nothing with this wrapper, so no functionality should be changed. Signed-off-by: Felipe Contreras

ruby: add keyword arguments to db.query

2021-06-27T17:13:03Z

That way we don't need pass them to the query object ourselves. Signed-off-by: Felipe Contreras

ruby: use notmuch_exclude_t enum

2021-05-23T12:05:33Z

It exists since 2013, let's allow it to be used in Ruby. Signed-off-by: Felipe Contreras

ruby: new notmuch_rb_object_destroy() helper

2021-05-17T10:25:14Z

The struct used to store the types (rb_data_type_t) contains a "data" field where we can store whatever we want. I use that field to store a pointer to the corresponding destroy function. For example notmuch_rb_database_type contains a pointer to notmuch_database_destroy. I cast that pointer as a notmuch_status_t (func*)(void *) and call that function passing the internal object (e.g. notmuch_database_t). Using the rb_data_type_t data we can call the correct notmuch destroy function. Therefore this: ret = ((notmuch_status_t (*)(void *)) type->data) (nm_object); Is effectively the same as this: ret = notmuch_database_destroy (database); The advantage of doing it this way is that much less code is necesary since each rb_data_type_t has the corresponding destroy function stored in it. Signed-off-by: Felipe Contreras

ruby: add all data types

2021-05-17T10:25:14Z

Signed-off-by: Felipe Contreras