notmuch/contrib, branch 0.35

notmuch-mutt: replace shell pipeline with internal pipe processing

2020-08-12T23:40:46Z

The shell pipeline used to symlink files based in search results to "cache" directory for mutt(1) to use was prone to portability problems (due to /bin/sh differences). The replacement executes `notmuch search` without intermediate shell (so shell_quote was removed in this case), reads the filenames from piped output and symlinks files internally.

Make notmuch-mutt script more portable

2020-03-23T01:57:25Z

The -D flag to install (used in the Makefile) is GNU-specific and does not work on BSD distributions (i.e. macOS). Likewise with the xargs -r flag. These changes use portable alternatives to these flags while preserving the exact behavior.

contrib/notmuch-mutt: add install target

2018-09-18T10:54:33Z

The main goal here is to be able to install the notmuch-mutt script with an absolute shebang. I have tried to make the notmuch-mutt Makefile use configure information from notmuch if available, but make suitable guesses if not.

Fix typos as found by codespell

2018-03-24T23:09:54Z

Signed-off-by: Georg Faerber

fix typos

2018-01-05T00:35:58Z

database: add n_d_index_file (deprecates n_d_add_message)

2017-08-23T10:38:37Z

We need a way to pass parameters to the indexing functionality on the first index, not just on reindexing. The obvious place is in notmuch_database_add_message. But since modifying the argument list would break both API and ABI, we needed a new name. I considered notmuch_database_add_message_with_params(), but the functionality we're talking about doesn't always add a message. It tries to index a specific file, possibly adding a message, but possibly doing other things, like adding terms to an existing message, or failing to deal with message objects entirely (e.g. because the file didn't contain a message). So i chose the function name notmuch_database_index_file. I confess i'm a little concerned about confusing future notmuch developers with the new name, since we already have a private _notmuch_message_index_file function, and the two do rather different things. But i think the added clarity for people linking against the future libnotmuch and the capacity for using index parameters makes this a worthwhile tradeoff. (that said, if anyone has another name that they strongly prefer, i'd be happy to go with it) This changeset also adjusts the tests so that we test whether the new, preferred function returns bad values (since the deprecated function just calls the new one). We can keep the deprecated n_d_add_message function around as long as we like, but at the next place where we're forced to break API or ABI we can probably choose to drop the name relatively safely. NOTE: there is probably more cleanup to do in the ruby and go bindings to complete the deprecation directly. I don't know those languages well enough to attempt a fix; i don't know how to test them; and i don't know the culture around those languages about API additions or deprecations.

Use rooted paths in .gitignore files

2017-08-18T22:42:35Z

A leading / in paths in a .gitignore file matches the beginning of the path, meaning that for patterns without slashes, git will match files only in the current directory as opposed to in any subdirectory. Prefix relevant paths with / in .gitignore files, to prevent accidentally ignoring files in subdirectories and possibly slightly improve the performance of "git status".

fixed wrong constant values

2016-09-03T23:15:46Z

before, they were both zero, so getting a read-writeable handle was impossible.

Added thread bindings to go bindings

2016-09-03T23:15:16Z

bindings: move go bindings to contrib

2016-09-03T23:13:08Z

This signals two things, an intent to be more liberal about accepting patches, and an intent to stop distributing the bindings if maintenance doesn't pick up.