notmuch/crypto.c, branch debian/0.24.2-2

Use https instead of http where possible

2016-06-05T11:32:17Z

Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.

cli: crypto: S/MIME verification support

2016-01-29T21:45:46Z

notmuch-show --verify will now also process S/MIME multiparts if encountered. Requires gmime-2.6 and gpgsm. Based on work by Jameson Graef Rollins .

cli: let the user know which protocol is unknown or unsupported

2015-12-30T15:28:30Z

The current error message is not helpful.

crypto: make crypto ctx initialization an array

2015-12-30T15:28:30Z

Make it trivial to add handlers for new protocols without duplicating code. No functional changes.

crypto: refactor context creation to facilitate further work

2015-12-30T15:28:30Z

Let the context creation functions decide how to handle multiple calls and cache the crypto context. No functional changes.

cli/lib: remove support for GMime 2.4

2015-08-26T23:01:45Z

It's becoming a maintenance burden to do anything things with the crypto glue code twice, once for 2.4 and once for 2.6. I don't have any 2.4 version available to test on my development machine anymore, so the 2.4 specific code paths are likely not very well tested.

CLI: set up infrastructure to make path to gpg configurable.

2015-03-09T07:19:28Z

GMIME takes a path to gpg, but we hardcode that path. In this commit we set up argument passing and option storage to allow this path to specified in the top level notmuch command.

crypto: return NULL cryptoctx if protocol string is empty.

2013-07-20T12:13:48Z

Badly formed messages that don't specify a protocol in signed/encrypted parts, end up with a protocol of NULL. strcasecmp in notmuch_crypto_get_context then segfaults when trying to check it against known protocols. If the protocol is NULL, just return an empty context immediately (with appropriate message.)

cli: crypto: abstract gpg context creation for clarity

2013-04-01T19:39:22Z

The code filled with #ifdef GMIME_ATLEAST_26 is difficult to read. Abstract gpg context creation into a function, with separate implementations for GMime 2.4 and 2.6, to clarify the code. There should be no functional changes.

cli: crypto: tell gmime to use gpg-agent

2013-03-02T14:41:24Z

For decryption, we expect there to be a functioning gpg-agent, and we want gpg to talk to it for any needed credentials. There's a gmime function to declare that: g_mime_gpg_context_set_use_agent() [1], [2]. Start using it. I had gpg-agent running, but gpg "use-agent" configuration option disabled. This resulted in an error message from 'notmuch show': Failed to decrypt part: Canceled. and json had this: "encstatus" : [ { "status" : "bad" } ] One could argue the "use-agent" option should be enabled, but I'd like to use the agent only as a last resort. I think that's irrelevant though. There's a gmime function to declare what we expect, so we should use it. Conveniently it also fixes the problem in a user friendly way. [1] http://git.gnome.org/browse/gmime/commit/?id=ed985397843a9da3745a8b5de3d1d652acd24724 [2] https://bugzilla.gnome.org/show_bug.cgi?id=651826