notmuch/crypto.c, branch master

crypto: move into libnotmuch_util

2017-10-20T10:58:10Z

This prepares us for using the crypto object in both libnotmuch and the client.

crypto: _notmuch_crypto_cleanup should return void

2017-10-13T01:11:55Z

There's no chance that _notmuch_crypto_cleanup() will ever return anything other than 0, and no one ever checks its return value anyway. So make it return void instead of int.

crypto: drop pretense of notmuch_crypto_context_t

2017-10-13T01:11:33Z

notmuch_crypto_context_t was introduced (i think) as some sort of abstraction layer to make notmuch somewhat independent of GMime. But it isn't even useful for GMime 3.0 or later -- we can drop the pretense that it's some sort of abstraction in this case, and just call it what it is, GMimeCryptoContext, which is useful for building against older versions of GMime. This also renames _notmuch_crypto_get_context() to _notmuch_crypto_get_gmime_context().

crypto: rename notmuch_crypto_t to _notmuch_crypto_t

2017-10-13T01:11:25Z

The notmuch_crypto_t struct isn't used externally, and we have no plans to explicitly export it. Prefix its name (and associated functions) with _ to make that intent clear.

cli: convert notmuch_bool_t to stdbool

2017-10-10T01:24:02Z

C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the cli and test binaries to stdbool.

crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3

2017-07-16T00:43:08Z

gmime 3.0 knows how to select the correct GMimeCryptoContext automatically, so a bunch of the code in notmuch can be dropped in that case. The #ifdef removal of the crypto stuff is better than #define aliasing in gmime-extra.h for this stuff. When built against gmime 3.0: * it reduces compiled code, and * it avoids initializing unused gpgme contexts (based on a patch from dkg)

Use https instead of http where possible

2016-06-05T11:32:17Z

Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.

cli: crypto: S/MIME verification support

2016-01-29T21:45:46Z

notmuch-show --verify will now also process S/MIME multiparts if encountered. Requires gmime-2.6 and gpgsm. Based on work by Jameson Graef Rollins .

cli: let the user know which protocol is unknown or unsupported

2015-12-30T15:28:30Z

The current error message is not helpful.

crypto: make crypto ctx initialization an array

2015-12-30T15:28:30Z

Make it trivial to add handlers for new protocols without duplicating code. No functional changes.