thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.3 2010-04-27T08:56:13Z 2010-04-27T08:56:13Z David Edmondson dme@dme.org 2010-04-27T07:00:44Z urn:sha1:1e1871154341cdd3413fe3f32e3aae477826d815 Re-working the saved search/tag insertion to buttonize only the name of the saved search/tag plus one space broke the calculation of how much filler is required to complete the column, resulting in lines wider than the window. 2010-04-27T05:42:07Z Carl Worth cworth@cworth.org 2010-04-27T05:42:07Z urn:sha1:a4669217600e4536dc0c49f0255af5e2d9bc183f We are asserting that the new notmuch-hello implementation, (available by just calling `notmuch') is just as easy to use as the old notmuch-folder. So let's remove what's now a largely redundant implementation. To make this transition easier, we are still supporting the notmuch-folders variable name, and we still provide `notmuch-folder' as an alias which can be invoked to get the new notmuch-hello functionality. 2010-04-27T05:40:31Z Carl Worth cworth@cworth.org 2010-04-27T05:40:31Z urn:sha1:fa5279113b8bc2d6f58d672867f980ef8f02a118 Previously, this was calling into a notmuch-folder-count function. Only, everything related to notmuch-folder is about to go away, so lets have notmuch-hello define its own function (notmuch-saved-search-count) for this purpose. 2010-04-27T05:37:11Z Carl Worth cworth@cworth.org 2010-04-27T05:37:11Z urn:sha1:f1f7e71e0347672e0658362c513e49c05b0f4161 We use this function to abstract away the common 3-step process for looking for a value for the saved-searches variable: 1. Look at the notmuch-saved-searches variable itself 2. Look at the notmuch-folders vaiable 3. Use a default value We were already using this logic (open-coded) in notmuch-hello, but notmuch.el was accessing notmuch-folders directly for the clever name selection of search buffers. 2010-04-27T05:33:09Z Carl Worth cworth@cworth.org 2010-04-27T05:33:09Z urn:sha1:4727eacb36245ccd2eabe22bfa408a099b574255 Apparently the declare-function macro doesn't work in a required file as I might like it too. Put it where it needs to go to avoid the warning. 2010-04-27T05:05:47Z Carl Worth cworth@cworth.org 2010-04-27T05:05:47Z urn:sha1:f8e372ebeccff4e2cba323d75ac1278cb22828b9 Just like the G keybinding we've had in notmuch-folder-mode and notmuch-search-mode, (to call `notmuch-poll' to 'G'et new mail). 2010-04-27T04:55:51Z Carl Worth cworth@cworth.org 2010-04-27T04:55:51Z urn:sha1:2a6a0e248174d93f431018ce8b809fc0fdebd847 I'm planning to rip out the notmuch-folder-mode completely. So as a token kindness to existing users of notmuch-folders, I'm at least making notmuch-hello support the notmuch-folders variable name as an alternate for the new name of notmuch-saved-searches. 2010-04-27T04:45:19Z Carl Worth cworth@cworth.org 2010-04-27T04:45:19Z urn:sha1:51e5eaac172b37a7000bff0a7e5cf1229239aba3 We've recently changed things so that the notmuch-hello screen is the default view one gets by executing `notmuch'. So hide the "hello" name from everything exposed in the customize interface, (leaving "hello" as just an internal name within the implementation). 2010-04-27T03:51:31Z Carl Worth cworth@cworth.org 2010-04-27T03:51:31Z urn:sha1:404c6121e5b255850052eea55d88f65c9c439590 After the previous commit, toggling the visibility of tags could result in notmuch-hello aborting with: Wrong type argument: wholenump, -1 At least, the error only occurred for me when making tags visible. But that may be because my longest tag name is longer than my longest saved-search name. 2010-04-27T03:15:45Z Carl Worth cworth@cworth.org 2010-04-27T03:15:45Z urn:sha1:ca5ae54cb1aa91dc2c3ba9372d70d6fa080851d8 After isearching for an entire saved-search name, the point will be immediately after that name in the buffer. Before commit c9ba61bebef7733c4bf12adf94222e57621fdcf6 the space right after the name was part of the widget so the user could press RET right after the isearch to activate the saved search. The above commit broke that functionality. Restore it by including a single space after each name as part of the widget.