thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.20 2015-01-25T17:39:13Z 2015-01-25T17:39:13Z Austin Clements amdragon@mit.edu 2015-01-24T21:17:00Z urn:sha1:3687418526b155668578c1d70ccd6d9b63de2200 (The actual code change here is small, but requires re-indenting existing code.) 2015-01-25T17:39:13Z Austin Clements amdragon@mit.edu 2015-01-24T21:16:59Z urn:sha1:9d19f325f5a0879e2f646e83e59595d5cb345de3 Unibyte strings are meant for representing binary data. In practice, using unibyte versus multibyte strings affects *almost* nothing. It does happen to matter if we use the binary data in an image descriptor (which is, helpfully, not documented anywhere and getting it wrong results in opaque errors like "Not a PNG image: <giant binary spew that is, in fact, a PNG image>"). 2015-01-25T17:39:13Z Austin Clements amdragon@mit.edu 2015-01-24T21:16:58Z urn:sha1:991efcded840944b2f7ebf97d4c9df51a3d011cf `notmuch-get-bodypart-content' could do two very different things, depending on conditions: for text/* parts other than text/html, it would return the part content as a multibyte Lisp string *after* charset conversion, while for other parts (including text/html), it would return binary part content without charset conversion. This commit completes the split of `notmuch-get-bodypart-content' into two different and explicit APIs: `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text'. It updates all callers to use one or the other depending on what's appropriate. 2015-01-25T17:39:13Z Austin Clements amdragon@mit.edu 2015-01-24T21:16:57Z urn:sha1:021906d6ec60360b5587ae08657fd6caa9a71b17 The new function, `notmuch-get-bodypart-binary', replaces `notmuch-get-bodypart-internal'. Whereas the old function was really meant for internal use in `notmuch-get-bodypart-content', it was used in a few other places. Since the difference between `notmuch-get-bodypart-content' and `notmuch-get-bodypart-internal' was unclear, these other uses were always confusing and potentially inconsistent. The new call clearly requests the part as undecoded binary. This is step 1 of 2 in separating `notmuch-get-bodypart-content' into two APIs for retrieving either undecoded binary or decoded text. 2014-10-31T16:54:21Z David Edmondson dme@dme.org 2014-10-29T14:18:49Z urn:sha1:30f1c43efe32c83193a6b9ae1f31ab2667e4195d When a user hits 'q' in a notmuch buffer, kill the buffer only if there are no other windows currently showing it. 2014-09-21T19:23:45Z Austin Clements amdragon@MIT.EDU 2014-04-21T18:37:38Z urn:sha1:0b94dd7fd3dcd071ebbe498cd80f5fd687a78e08 This can be derived from the PART argument (which is arguably canonical), so there's no sense in giving the caller an extra foot gun. 2014-08-05T11:07:27Z Austin Clements amdragon@MIT.EDU 2014-08-05T01:45:20Z urn:sha1:3c1ad5bfa0039191f1202b0542eb3af7afd16c5c This introduces notmuch-jump, which is like a user-friendly, user-configurable global prefix map for saved searches. This provides a non-modal and much faster way to access saved searches than notmuch-hello. A user configures shortcut keys in notmuch-saved-searches, which are immediately accessible from anywhere in Notmuch under the "j" key (for "jump"). When the user hits "j", the minibuffer immediately shows a helpful table of bindings reminiscent of a completions buffer. This code is a combination of work from myself (originally, "notmuch-go"), David Edmondson, and modifications from Mark Walters. 2014-07-31T10:10:47Z Austin Clements amdragon@MIT.EDU 2014-07-24T21:19:31Z urn:sha1:8251d639b2e4f38db097fad283e61fac93d644f7 notmuch-poll-script has long since been deprecated in favor of post-new hooks, but this wasn't obvious from the documentation. Update the documentation to make this clear. Since notmuch-poll-script could, to some extend, be used to control the path of the notmuch binary and that use is now clearly discouraged, promote notmuch-command to a real defcustom instead of just a variable. 2014-04-21T12:48:41Z Mark Walters markwalters1009@gmail.com 2014-04-16T21:21:53Z urn:sha1:ae2888015e41174aa34203f397ffa034b56cfc61 The recent changes for saved searches introduced a bug when notmuch was loaded after the saved search was defined. This was caused by a utility function not being defined when the defcustom was loaded. Fix this by moving some code around: the defcustom is moved into notmuch-hello (which is a more natural place anyway), and the utility functions are moved before the defcustom in notmuch-hello. We are rather constrained as the defcustom for saved searches is the first variable in the notmuch-hello customize window; to avoid moving this customize the defcustom needs to be the first defcustom in notmuch-hello, and the utility functions come before that. This patch also renames one of the utility functions from notmuch--saved-searches-to-plist to notmuch-hello--saved-searches-to-plist (as it is purely local to notmuch-hello) and corrects a couple of typo/spelling mistakes pointed out by Tomi. 2014-04-11T13:27:26Z Mark Walters markwalters1009@gmail.com 2014-04-06T05:44:49Z urn:sha1:f225ee59ebdbd6961a0665f7e912825fbcc691d1 This adds a sort-order option to saved-searches, stores it in the saved-search buttons (widgets), and uses the stored value when the button is pressed. Storing the sort-order in the widget was suggested by Jani in id:4c3876274126985683e888641b29cf18142a5eb8.1391771337.git.jani@nikula.org.