notmuch/emacs/notmuch-lib.el, branch 0.31thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.312020-08-10T00:17:39Zemacs: Use new advice mechanism do advice mm-shr2020-08-10T00:17:39ZJonas Bernoullijonas@bernoul.li2020-08-08T11:50:08Zurn:sha1:6336c26d2341b390c995b5579bf590415db29420
Also because we now only support Emacs >= 25,
we can remove the check for Emacs >= 24.
emacs: Use cl-incf where appropriate2020-08-10T00:15:27ZJonas Bernoullijonas@bernoul.li2020-08-08T11:50:03Zurn:sha1:9946380e47ffcffea7fb9793a9fe4944b510110f
It's shorter. That's it pretty much.
Fix typos2020-08-10T00:14:36ZJonas Bernoullijonas@bernoul.li2020-08-08T11:49:55Zurn:sha1:6c84dee53193a78cf797b44d3febcc14488ea6b1emacs: Increase consistency of library headers2020-08-10T00:14:36ZJonas Bernoullijonas@bernoul.li2020-08-08T11:49:54Zurn:sha1:df3fab18fe70ea750f6f06da30291c67de7e74f2emacs: Various cosmetic changes2020-08-10T00:14:36ZJonas Bernoullijonas@bernoul.li2020-08-08T11:49:53Zurn:sha1:73b8f0b8d71af395667022395b6d6bb692c3aaf2emacs: Autoload notmuch-jump-search only once2020-08-10T00:14:36ZJonas Bernoullijonas@bernoul.li2020-08-08T11:49:51Zurn:sha1:c2e9ec17fd46e67c7cf1f06d4c6da2ed59da34d9
This function is being autoloaded using an autoload cookie, so it
shouldn't additionally be autoloaded using an `autoload' form.
When building libraries we don't actually load the autoloads file and
dropping the `autoload' form results in an error, which reveals a so
far unspecified dependency: `notmuch-tree' needs `notmuch-jump'.
Before this commit compiling (or even just loading) `notmuch-tree'
resulted in `notmuch-jump' being loaded because the former requires
`notmuch-lib', which autoloaded `notmuch-jump-search'.
The bug was that this dependency was not explicitly specified, which
we fix by adding the respective `require' form.
emacs: notmuch-poll: Let the user know we are polling2020-08-09T23:59:11ZJonas Bernoullijonas@bernoul.li2020-08-08T11:49:48Zurn:sha1:177cd31fbdff93254d576b737b55656d3a6086b5
It is done synchronously and it can take a while,
so we should let the user know what is going on.
emacs: Use one or three lines for 'if' forms2020-08-09T23:53:30ZJonas Bernoullijonas@bernoul.li2020-08-08T11:49:44Zurn:sha1:99b6e780c8714f90f476e989e2d1cd973cf5bbb9
Putting the COND and THEN parts on the same line but ELSE on a
separate line makes it harder to determine if there actually is
an ELSE part.
emacs: Use 'when' instead of 'if' when there is no ELSE part2020-08-09T23:52:34ZJonas Bernoullijonas@bernoul.li2020-08-08T11:49:43Zurn:sha1:e1a700067a22214f54064c281219fbbbef87de06emacs: Use 'and' instead of 'when' when the return value matters2020-08-09T23:51:16ZJonas Bernoullijonas@bernoul.li2020-08-08T11:49:41Zurn:sha1:dfb1b8eb89e814f4bf6f6e62b700c72aa1b4659a
Also do so for some 'if' forms that lack an ELSE part.
Even go as far as using 'and' and 'not' instead of 'unless'.