thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=master 2021-01-15T10:47:10Z 2021-01-15T10:47:10Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:01:08Z urn:sha1:f3d6fa2e40c45c3dbaef768e36f1544248851ddb Like `cl-lib' and `pcase', which are already available in all libraries, `subr-x' also provided many useful functions that we would like to use. Making `subr-x' available in every library from the get-go means that we can use the functions it defines without having to double check every single time, whether the feature is already available in the current library. 2021-01-15T10:46:38Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:01:07Z urn:sha1:9ca1f945d9f5030600dc14ffff10d4dad14db4ca We need to load `cl-lib' at run-time because we use more from it than just macros. Never-the-less many, but not all libraries required it only at compile-time, which we got away with because at least some libraries already required it at run-time as well. We use `cl-lib' and (currently to a lesser extend) `pcase' throughout the code-base, which means that we should require these features in most libraries. In the past we tried to only require these features in just the libraries that actually need them, without fully succeeding. We did not succeed in doing so because that means we would have to check every time that we use a function from these features whether they are already being required in the current library. An alternative would be to add the `require' forms at the top of every library but that is a bit annoying too. In order to make sure that these features are loaded when needed but also to keep the noise down we only require them in "notmuch-lib.el", which most other libraries require, and in most of the few libraries that do not do so, namely "notmuch-draft.el", "notmuch-message.el" and "notmuch-parser.el". ("coolj.el", "make-deps.el", various generated libraries, and "notmuch-compat.el" are left touched.) 2021-01-13T11:23:11Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:00:54Z urn:sha1:b4deb33a66d6781fb6e516053efe67c60e934b63 2021-01-13T11:21:32Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:00:53Z urn:sha1:117501d5ceb332063adfeadc961e8c053f2cd942 Also improve the doc-string. 2021-01-13T11:16:04Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:00:47Z urn:sha1:fc4cda07a9afbbb545dcc6cd835ca697f6ef2a1b Doing so causes many new compile warnings. Some of these warnings concern genuine changes in behavior that have to be addressed right away. Many other warnings are due to unused variables. Nothing has changed here, except that the byte-compiler can now detect these pre-existing and harmless issues. We delay addressing these issues so that we can focus on the important ones here. A third group of warnings concern arguments that are not actually used inside the function but which cannot be removed because the functions signature is dictated by some outside convention. Silencing these warning is also delayed until subsequent commits. 2020-08-09T22:48:36Z Jonas Bernoulli jonas@bernoul.li 2020-08-08T11:49:36Z urn:sha1:a4617f29ce81e7ae3e0cb747fdb9070f88407a28 2019-04-14T11:00:44Z Örjan Ekeberg ekeberg@kth.se 2019-04-12T12:01:12Z urn:sha1:606f2a66157cf5d58a6d187e0163249a4e61ecc8 Use the buffer-local variable notmuch-message-queued-tag-changes to change tags when the forwarding message is sent. 2019-04-14T10:58:06Z Örjan Ekeberg ekeberg@kth.se 2019-04-12T12:01:11Z urn:sha1:d9800c893289b56dcc966241528643ae83f2ff9a Instead of relying on the "In-Reply-To" header, use a buffer-local variable, notmuch-message-queued-tag-changes, to add and remove tags to affected messages when the message-send-hook is triggered. 2016-06-05T11:32:17Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2016-06-02T16:26:14Z urn:sha1:6a833a6e83865f6999707cc30768d07e1351c2cb Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests. 2016-04-16T11:24:42Z Chunyang Xu xuchunyang.me@gmail.com 2016-04-13T07:58:47Z urn:sha1:0cf457b73b4b666314d1a09ac3e31bd0fa2346a6 Refer to (info "(elisp) Library Headers") for package conventions.