thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=master 2023-10-06T23:36:56Z 2023-10-06T23:36:56Z David Bremner david@tethera.net 2023-10-01T11:43:11Z urn:sha1:fc1c81c3784a699d57c15ab743c819704964430b The complicated looking escapes are needed to avoid compile time warnings. (info "(elisp) Text Quoting Style") for details. 2021-09-11T13:19:27Z David Bremner david@tethera.net 2021-08-29T19:23:30Z urn:sha1:5e5f2122f91413e93761ca4a3d30b0b8b0d5e38e As with notmuch--process-lines, initial purpose is to provide a safe binding for default-directory. This is enough to make notmuch-hello robust against non-existent or corrupt values default-directory, but probably not other views. 2021-01-13T11:16:23Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:00:48Z urn:sha1:0067a43ea2ee554eafed1e1300a71259cd6b6a6d The previous commit switched to lexical-binding but without dealing with the new warnings about unused lexical arguments and variables. This commit deals with most of them, in most cases by either removing leftover bindings that are actually unnecessary, or by marking certain arguments as "known to be unused" by prefixing their names with "_". In the case of the functions named `notmuch-show-insert-...' the amount of silencing that is required is a bit extreme and we might want to investigate if there is a better way. In the case of `notmuch-mua-mail', ignoring CONTINUE means that we do not fully follow the intended behavior described in `compose-mail's doc-string. 2021-01-13T11:16:04Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:00:47Z urn:sha1:fc4cda07a9afbbb545dcc6cd835ca697f6ef2a1b Doing so causes many new compile warnings. Some of these warnings concern genuine changes in behavior that have to be addressed right away. Many other warnings are due to unused variables. Nothing has changed here, except that the byte-compiler can now detect these pre-existing and harmless issues. We delay addressing these issues so that we can focus on the important ones here. A third group of warnings concern arguments that are not actually used inside the function but which cannot be removed because the functions signature is dictated by some outside convention. Silencing these warning is also delayed until subsequent commits. 2021-01-13T11:10:27Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:00:46Z urn:sha1:2ca941163da06aed564dab1990fb333fd7457ec2 `outline-minor-mode' treats comments that begin with three or more semicolons as headings. That makes it very convenient to navigate code and to show/hide parts of a file. Elips libraries typically have four top-level sections, e.g.: ;;; notmuch.el --- run notmuch within emacs... ;;; Commentary:... ;;; Code:... ;;; notmuch.el ends here In this package many libraries lack a "Commentary:" section, which is not optimal but okay for most libraries, except major entry points. Depending on how one chooses to look at it, the "... ends here" line is not really a heading that begins a section, because it should never have a "section" body (after all it marks eof). If the file is rather short, then I left "Code:" as the only section that contains code. Otherwise I split the file into multiple sibling sections. The "Code:" section continues to contain `require' and `declare-function' forms and other such "front matter". If and only if I have split the code into multiple sections anyway, then I also added an additional section named just "_" before the `provide' form and shortly before the "...end here" line. This section could also be called "Back matter", but I feel it would be distracting to be that explicit about it. (The IMO unnecessary but unfortunately still obligatory "... ends here" line is already distracting enough as far as I am concerned.) Before this commit some libraries already uses section headings, some of them consistently. When a library already had some headings, then this commit often sticks to that style, even at the cost inconsistent styling across all libraries. A very limited number of variable and function definitions have to be moved around because they would otherwise end up in sections they do not belong into. Sections, including but not limited to their heading, can and should be further improved in the future. 2020-08-10T00:14:36Z Jonas Bernoulli jonas@bernoul.li 2020-08-08T11:49:54Z urn:sha1:df3fab18fe70ea750f6f06da30291c67de7e74f2 2019-01-30T11:15:59Z David Bremner david@tethera.net 2019-01-30T11:15:59Z urn:sha1:617b36f3d1e9ccdf4f0a44baba84a3d8ac76afcf Joerg Jaspert [1] reported problems with evince reading unsuffixed temporary files in Debian. [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920856 2016-06-05T11:32:17Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2016-06-02T16:26:14Z urn:sha1:6a833a6e83865f6999707cc30768d07e1351c2cb Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests. 2016-04-16T11:24:42Z Chunyang Xu xuchunyang.me@gmail.com 2016-04-13T07:58:47Z urn:sha1:0cf457b73b4b666314d1a09ac3e31bd0fa2346a6 Refer to (info "(elisp) Library Headers") for package conventions. 2012-04-25T02:25:51Z Austin Clements amdragon@MIT.EDU 2012-04-16T02:57:45Z urn:sha1:ff53fb468e160c8c6910078cfa92dcb6b5caa728