notmuch/emacs/notmuch.el, branch 0.31

Emacs: Fix notmuch-message-summary-face definition

2020-08-22T12:23:26Z

Emacs face definition forms are either ((DISPLAY . PLIST) (DISPLAY . PLIST)) or ((DISPLAY PLIST) ;For backward compatibility. (DISPLAY PLIST)) Commit a2388bc56e55da5d5695816818274f8a84b0ed92 (2020-08-08) follows neither of the correct formats. It defines: `((((class color) (background light)) ,@(and (>= emacs-major-version 27) '(:extend t)) (:background "#f0f0f0")) (((class color) (background dark)) ,@(and (>= emacs-major-version 27) '(:extend t)) (:background "#303030"))) which produces: ((DISPLAY :extend t (:background "#f0f0f0")) (DISPLAY :extend t (:background "#303030"))) And that is wrong format. This change fixes the face definition form to produce: ((DISPLAY :extend t :background "#f0f0f0") (DISPLAY :extend t :background "#303030")) which follows the (DISPLAY . PLIST) format (see above).

emacs: Use pop-to-buffer-same-window rather than switch-to-buffer

2020-08-22T12:11:06Z

This means that notmuch commands obey display-buffer-alist so the user can customize how buffers show up. It also permits the use of C-x 4 4, C-x 5 5 and C-x t t, available in Emacs 28. For example, one can use C-x 4 4 M-x notmuch-jump-search RET to open a saved search in another window rather than the current window. Or in notmuch-search mode, C-x 5 5 RET to view the message at point in a new frame. notmuch-tree has custom buffer display logic, so bind display-buffer-overriding-action to make pop-to-buffer-same-window behave exactly as switch-to-buffer while that function is running.

emacs/tree: introduce notmuch-tree-parent-buffer variable

2020-08-16T13:42:02Z

This variable will be used in a similar fashion to notmuch-show-parent-buffer. It will be used to navigate between threads from the parent search buffer. Signed-off-by: William Casarin

emacs: Increase consistency of library headers

2020-08-10T00:14:36Z

emacs: Improve doc-strings

2020-08-10T00:14:36Z

- The first sentence should fit on the first line in full. This is even the case when that causes the line to get a bit long. If it gets very long, then it should be made shorter. - Even even the second sentence would fit on the first line, if it just provides some details, then it shouldn't be done. - Symbols are quoted like `so'. - There is no clear rule on how to (not) quote non-atomic s-expressions, but quoting like '(this) is definitely weird. - It is a good idea to remember that \" becomes " and to take that in mind when adjusting the automatic filling by hand. - Use the imperative form. - Arguments are written in all uppercase.

emacs: Extend face to window edge again

2020-08-09T23:53:46Z

Since Emacs 27 each face has to be explicitly configured to "extend to the edge of the window". Without doing that the face used for the newline character only has an effect that spans "one character" (i.e. it looks like there is a single trailing space character). We don't want that so extend the face in Emacs 27, so that it looks the same as it did in older Emacs releases. We have to do this conditionally, otherwise older Emacsen would choke on it.

emacs: Use 'when' instead of 'if' when there is no ELSE part

2020-08-09T23:52:34Z

emacs: Use 'unless' instead of 'when' and 'not'

2020-08-09T23:51:26Z

Also use 'unless' in a few cases where previously 'if' was used with 'not' but without an ELSE part.

emacs: Use 'and' instead of 'when' when the return value matters

2020-08-09T23:51:16Z

Also do so for some 'if' forms that lack an ELSE part. Even go as far as using 'and' and 'not' instead of 'unless'.

emacs: Only set one variable per setq form

2020-08-09T23:50:50Z

It's a bit weird to avoid having to write the "(setq ... )" more than once, just because we can. In a language that uses '=' for the same purpose we also happily use that once per assignment. While there are no benefit to using just one 'setq' there are some drawbacks. It is not always clear on first what is a key and what a value and as a result it is easy to make a mistake. Also it becomes harder to comment out just one assignment.