notmuch/emacs, branch 0.20

emacs: show: hide large text attachments by default

2015-04-03T00:29:05Z

notmuch-show can be slow displaying large attachments so hide them by default. The default maximum size is 10000 bytes/characters but it is customizable. Note that notmuch-show-insert-bodypart is also called from the reply code so we need to be a little careful.

emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-02T22:07:01Z

It's default value is ".", meaning all remote images will be blocked by default.

emacs: Support cid: references with shr renderer

2015-01-25T17:39:13Z

shr has really nice support for inline image rendering, but previously we only had the hooks for w3m cid: references.

emacs: Rewrite content ID handling

2015-01-25T17:39:13Z

Besides generally cleaning up the code and separating the general content ID handling from the w3m-specific code, this fixes several problems. Foremost is that, previously, the code roughly assumed that referenced parts would be in the same multipart/related as the reference. According to RFC 2392, nothing could be further from the truth: content IDs are supposed to be globally unique and globally addressable. This is nonsense, but this patch at least fixes things so content IDs can be anywhere in the same message. As a side-effect of the above, this handles multipart/alternate content-IDs more in line with RFC 2046 section 5.1.2 (not that I've ever seen this in the wild). This also properly URL-decodes cid: URLs, as per RFC 2392 (the previous code did not), and applies crypto settings from the show buffer (the previous code used the global crypto settings).

emacs: Use generalized content caching in w3m CID code

2015-01-25T17:39:13Z

Previously this did its own caching, but this is now supported by more generally by `notmuch-get-bodypart-binary'.

emacs: Support caching in notmuch-get-bodypart-{binary,text}

2015-01-25T17:39:13Z

(The actual code change here is small, but requires re-indenting existing code.)

emacs: Return unibyte strings for binary part data

2015-01-25T17:39:13Z

Unibyte strings are meant for representing binary data. In practice, using unibyte versus multibyte strings affects *almost* nothing. It does happen to matter if we use the binary data in an image descriptor (which is, helpfully, not documented anywhere and getting it wrong results in opaque errors like "Not a PNG image: ").

emacs: Remove broken `notmuch-get-bodypart-content' API

2015-01-25T17:39:13Z

`notmuch-get-bodypart-content' could do two very different things, depending on conditions: for text/* parts other than text/html, it would return the part content as a multibyte Lisp string *after* charset conversion, while for other parts (including text/html), it would return binary part content without charset conversion. This commit completes the split of `notmuch-get-bodypart-content' into two different and explicit APIs: `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text'. It updates all callers to use one or the other depending on what's appropriate.

emacs: Create an API for fetching parts as undecoded binary

2015-01-25T17:39:13Z

The new function, `notmuch-get-bodypart-binary', replaces `notmuch-get-bodypart-internal'. Whereas the old function was really meant for internal use in `notmuch-get-bodypart-content', it was used in a few other places. Since the difference between `notmuch-get-bodypart-content' and `notmuch-get-bodypart-internal' was unclear, these other uses were always confusing and potentially inconsistent. The new call clearly requests the part as undecoded binary. This is step 1 of 2 in separating `notmuch-get-bodypart-content' into two APIs for retrieving either undecoded binary or decoded text.

emacs: Track full message and part descriptor in w3m CID store

2015-01-25T17:39:12Z

This will simplify later changes.