notmuch/emacs, branch 0.3

emacs: Fix column alignment in `notmuch-hello-insert-tags'

2010-04-27T08:56:13Z

Re-working the saved search/tag insertion to buttonize only the name of the saved search/tag plus one space broke the calculation of how much filler is required to complete the column, resulting in lines wider than the window.

emacs: Use message-signature-separator rather than hard-coded string.

2010-04-27T06:12:58Z

It's possible that the user has instructed message-mode to use some other separator. If so, then that's what we should look for when looking for the signature. Thanks to David Edmondson for pointing this out.

emacs: Delete some trailing whitespace.

2010-04-27T06:09:08Z

That managed to sneak in with some recent improvements to the Fcc code.

emacs: Ensure that message-directory for Fcc has a trailing slash

2010-04-27T06:06:54Z

Use `file-name-as-directory' to ensure that message-directory has a trailing slash so it can be combined with the notmuch-fcc-dirs correctly.

emacs: add prompt to create maildir for fcc if it does not exist.

2010-04-27T06:06:50Z

If the user specifies a maildir that does not exist, prompt the user to see whether a maildir should be created. This will fail, with the relevant explanation, if the location is not writable, or if a file already exists in that location. If the location is a dir, but not a maildir, this will add /tmp/cur/new to it.

emacs: fcc should fail at the right time if it doesn't point to a maildir

2010-04-27T06:06:36Z

Throw an error after the maildir is generated but before the message is sent. This change allows the user to edit the maildir if it fails, so that it will point to a correct place. Note that this changes the previous behavior which always overwrote the existing Fcc line. Now, an Fcc line is only auto-generated if there isn't one already there. The ideal change would be to prompt to create a maildir. This should enable a place for doing that in a future patch.

emacs: Tweak search-buffer naming to search list in reverse order

2010-04-27T06:00:20Z

The complete-string matching of commit f2ebe3ac446afda9ced6507dc391865464ccdcaa defeats the substitution of partial search strings when the user manually types a long search string that just happens to partially match a saved search. For example, typing "tag:inbox and not tag:foo" should result in "[inbox] and not tag:foo" but this has been broken since that commit. As a compromise between this feature and what the commit was trying to achieve, we now reverse the saved-searches list before looking for a match. This happens to work for me, but won't necessarily work in general. What we really want is the longest match, but rassoc-if just gives us the first match. All of this is just about creating slightly nice search-buffer names. So if anyone really cares about making the names *even* nicer, then they could improve this further.

emacs: Rename search buffers with "saved-search" not "folder"

2010-04-27T05:58:46Z

Since we recently renamed everything from notmuch-folders to notmuch-saved-searches, fix up the generated names in the search buffers to match.

emacs: Match entire saved-search when computing search-view buffer name

2010-04-27T05:49:45Z

I happen to have a lot of saved searches that are variants of the tag:inbox search, (such as "tag:inbox and tag:notmuch"). The logic for these was always matching inbox first, resulting in "[ inbox ] and tag:notmuch" rather than "notmuch" as desired. Anchor the regular expression on both ends to make it look harder for the better match.

emacs: Rip out all of the notmuch-folder code.

2010-04-27T05:42:07Z

We are asserting that the new notmuch-hello implementation, (available by just calling `notmuch') is just as easy to use as the old notmuch-folder. So let's remove what's now a largely redundant implementation. To make this transition easier, we are still supporting the notmuch-folders variable name, and we still provide `notmuch-folder' as an alias which can be invoked to get the new notmuch-hello functionality.