notmuch/emacs, branch 0.3.1

emacs: Remove conditional from notmuch-fcc-initialization.

2010-04-27T18:10:50Z

The fcc code would only initialize if notmuch-fcc-dirs was set. This was a problem if you reset the variable, or added the variable later during initialization. Now we always add the fcc hook, but it doesn't do anything unless notmuch-fcc-dirs are set. (cherry picked from commit 80a90787163690d2d87571327ba504a470798c60)

emacs: Fix `notmuch-hello-insert-tags' to correctly draw the tags.

2010-04-27T18:08:11Z

The fix in 1e1871154341cdd3413fe3f32e3aae477826d815 broke end-of-row wrapping when drawing the table of tags/saved searches. Fix that and improve the readability of the matrix reflection code to hasten future debugging. (cherry picked from commit 08561d8ae133704fcf15edbdd47f15474dc030d5)

emacs: If 'all tags' is not shown, don't use it when calculating widths.

2010-04-27T18:08:00Z

If the 'all tags' section of the hello buffer will not be shown, don't consider those tags when determining the number of saved searches that can be displayed on a single line. (cherry picked from commit 18d41192d2cf0c71045c2f6420eb2311553f58b4)

emacs: Fix column alignment in `notmuch-hello-insert-tags'

2010-04-27T08:56:13Z

Re-working the saved search/tag insertion to buttonize only the name of the saved search/tag plus one space broke the calculation of how much filler is required to complete the column, resulting in lines wider than the window.

emacs: Use message-signature-separator rather than hard-coded string.

2010-04-27T06:12:58Z

It's possible that the user has instructed message-mode to use some other separator. If so, then that's what we should look for when looking for the signature. Thanks to David Edmondson for pointing this out.

emacs: Delete some trailing whitespace.

2010-04-27T06:09:08Z

That managed to sneak in with some recent improvements to the Fcc code.

emacs: Ensure that message-directory for Fcc has a trailing slash

2010-04-27T06:06:54Z

Use `file-name-as-directory' to ensure that message-directory has a trailing slash so it can be combined with the notmuch-fcc-dirs correctly.

emacs: add prompt to create maildir for fcc if it does not exist.

2010-04-27T06:06:50Z

If the user specifies a maildir that does not exist, prompt the user to see whether a maildir should be created. This will fail, with the relevant explanation, if the location is not writable, or if a file already exists in that location. If the location is a dir, but not a maildir, this will add /tmp/cur/new to it.

emacs: fcc should fail at the right time if it doesn't point to a maildir

2010-04-27T06:06:36Z

Throw an error after the maildir is generated but before the message is sent. This change allows the user to edit the maildir if it fails, so that it will point to a correct place. Note that this changes the previous behavior which always overwrote the existing Fcc line. Now, an Fcc line is only auto-generated if there isn't one already there. The ideal change would be to prompt to create a maildir. This should enable a place for doing that in a future patch.

emacs: Tweak search-buffer naming to search list in reverse order

2010-04-27T06:00:20Z

The complete-string matching of commit f2ebe3ac446afda9ced6507dc391865464ccdcaa defeats the substitution of partial search strings when the user manually types a long search string that just happens to partially match a saved search. For example, typing "tag:inbox and not tag:foo" should result in "[inbox] and not tag:foo" but this has been broken since that commit. As a compromise between this feature and what the commit was trying to achieve, we now reverse the saved-searches list before looking for a match. This happens to work for me, but won't necessarily work in general. What we really want is the longest match, but rassoc-if just gives us the first match. All of this is just about creating slightly nice search-buffer names. So if anyone really cares about making the names *even* nicer, then they could improve this further.