thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.32 2021-02-05T14:12:53Z 2021-02-05T14:12:53Z David Edmondson dme@dme.org 2021-02-03T09:10:20Z urn:sha1:8b7c09c66bbae35c52150a5ee81b94a82b2b3054 When prompting for one or more tags to add or remove to/from one or more threads, ensure that the set of tags offered for completion contains no duplicates. Some completion packages (e.g. selectrum) will include every member of the offered list, resulting in the same tag being indicated as a possibility several times. 2021-01-15T11:30:33Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T18:47:22Z urn:sha1:1f14dbfbd72d5c4aa04c4903155060f7c69c608f The output of "notmuch show --format=sexp --format-version=4" may contain `:content-type' entries with `nil' as the value, when it fails to detect the correct value. Account for that in a few places where we would otherwise risk a type error. Note that `string=' does not choke on `nil' because it uses the `symbol-name' when encountering a symbol. 2021-01-15T11:30:14Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T18:47:21Z urn:sha1:f1ae9addc6ca974393062c764518895af5f295c4 2021-01-15T11:30:00Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T18:47:20Z urn:sha1:99bf983d8c1eab623f8a3eec59b593645160f472 2021-01-15T11:29:09Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T18:47:19Z urn:sha1:6cae6f32b197f863c2e53a8fc28d888998a4fb7c 2021-01-15T10:49:07Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:01:12Z urn:sha1:a2bf29ad359539ed48a75ebb593897382d9a1de4 Users may type some text into the buffer on an address line, before actually invoking address completion. We now use that text as the initial input when we begin address completion. Previously we did knowingly replace the actual initial input with some completion candidate that happens to match. Which candidate is used is essentially random, at least when the actual initial input is short. As a result users very often had to begin completion by deleting the less than helpful "initial input". 2021-01-15T10:48:24Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:01:11Z urn:sha1:055294454fb944a2aec062fbb974665b02d9eaeb IMO Notmuch should not override the default completion mechanism by default, at least not globally. But since users are already used to this behavior it is probably too late to change it. Do the next best thing and at least allow users to opt out. 2021-01-15T10:47:48Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:01:10Z urn:sha1:9b5fd49ab2af70e75284c8df6c3d9765b6f22a76 When called from code, then this function returns non-nil when the message at point is a matched message. However it does nothing at all to present that information to the user when it called interactively. It is therefore safe to conclude that nobody is using this as a command. 2021-01-15T10:47:28Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:01:09Z urn:sha1:371f481d93073cad23f7ce8579a83a4db09147ef 2021-01-15T10:47:10Z Jonas Bernoulli jonas@bernoul.li 2021-01-10T14:01:08Z urn:sha1:f3d6fa2e40c45c3dbaef768e36f1544248851ddb Like `cl-lib' and `pcase', which are already available in all libraries, `subr-x' also provided many useful functions that we would like to use. Making `subr-x' available in every library from the get-go means that we can use the functions it defines without having to double check every single time, whether the feature is already available in the current library.