notmuch/emacs, branch 0.4

Fix problem with notmuch-hello-nice-number

2010-10-29T22:49:01Z

Without this little patch notmuch fails if asked to display a saved search that has zero results Edited-by: David Edmondson : With code that is a little more "emacsy".

emacs: Re-work the implementation of highlighting in notmuch-search-mode.

2010-10-29T22:30:43Z

Re-write `notmuch-search-color-line', with the following improvements: - create overlays only if they will be needed, - merge the properties specified for a tag on top of any matching a previous tag.

emacs: Fix the autoload comments

2010-10-29T22:27:01Z

Remove them from non-top-level entry points, (such as the functions to set notmuch modes and the deprecated notmuch-folder function). And add one to the notmuch-hello function. Also, add missing documentation string to notmuch-hello.

Don't involve the shell in notmuch searches

2010-10-29T21:13:51Z

The shell isn't needed to interpret any of the arguments, so don't bother using it at all. Signed-off-by: David Benjamin

emacs: Use copy-sequence instead of copy-seq.

2010-10-28T18:35:58Z

I don't see copy-seq documented within emacs at all, and some users have encountered failures of the form: notmuch-show-del-tags-worker: Symbol's function definition is void: copy-seq This should eliminate that problem.

emacs: Eliminate duplicate From header in replies.

2010-10-28T01:44:05Z

The original code was intended to work, but clearly wasn't tested. Use mail-header (as in existing code) to extract a header from a header alist. This fixes the duplicate-from-line bug that is exercised by the test just added to the test suite.

emacs: Eliminate warning of calling function with excess arguments.

2010-10-28T01:04:38Z

Yet another case of "how could this have possibly worked before?!". I guess we were just getting very lucky with the emacs lisp calling conventions and what happens with extra arguments, but, ick! Much better now.

emacs: Remove non-interactive call of goto-line

2010-10-28T00:58:19Z

As the emacs compiler warns, the goto-line function is only intended for interactive use. Instead use the approach recommended in the goto-line documentation to avoid this.

emacs: Fix to eliminate warning in notmuch-query-map-aux

2010-10-28T00:54:38Z

This is one of those cases where the warning looks absolutely correct, (complaining about a free variable), but I'm left wondering how the original code could have worked at all. From what I can tell, this code wasn't actually being called by any of the current code in notmuch.

emacs: Avoid runtime use of `cl'.

2010-10-28T00:41:50Z

The GNU Emacs Lisp Reference Manual section D.1 says: > * Please don't require the cl package of Common Lisp extensions at > run time. Use of this package is optional, and it is not part of > the standard Emacs namespace. If your package loads cl at run time, > that could cause name clashes for users who don't use that package. > > However, there is no problem with using the cl package at compile > time, with (eval-when-compile (require 'cl)). That's sufficient for > using the macros in the cl package, because the compiler expands > them before generating the byte-code. Follow this advice, requiring the following changes where `cl' was used at runtime: - replace `rassoc-if' in `notmuch-search-buffer-title' with the `loop' macro and inline code. At the same time find the longest prefix which matches the query rather than simply the last, - replace `union', `intersection' and `set-difference' in `notmuch-show-add-tag' and `notmuch-show-remove-tag' with local code to calculate the result of adding and removing a list of tags from another list of tags.