notmuch/emacs, branch 0.7

emacs: Fix to unconditionally display subject changes in collapsed thread view

2011-07-01T09:00:25Z

The feature to show subject changes in the collapsed thread view was originally added (8ab433607) with an option (notmuch-show-always-show-subject) to display the subject for all messages, even when there was no change. The subsequent commit (4f04d273) changed the sense of the test (or to and) and the name of the controlling variable (notmuch-show-elide-same-subject). But this commit is broken in a few ways: 1. The original definition of notmuch-show-always-show-subject was left around But the variable isn't actually used in the code at all, so it just adds clutter and confusion to the customization interface. 2. The name and description of the controlling variable doesn't match the implementation The name suggests that setting the variable to t will cause repeated subjects to be elided, (suggesting that when it is nil all subjects will be shown). However, when the variable is nil, no subjects are shown. So a correct name for the variable in this sense would be notmuch-show-subject-changes. Showing subject changes is a useful feature, and should be on by default. (We don't want to bury generally useful features behind customizations that users have to find). Rather than fixing the name of the variable and changing its default value, here we remove the condition entirely, such that the feature is enabled unconditionally. So both the currently-used variable and the stale definition of the formerly-used are removed. Also, the one relevant test-suite result is updated, (showing the intial subject of a collapsed thread, and no subject display for later messages that do not change the subject).

Makefile: Make emacs compilation depend on global dependencies.

2011-06-28T18:59:48Z

We call these "global_deps" for a reason, after all! Without this, emacs compilation would proceed even if the configure script failed, (such as for a missing dependency). That's undesirable as it can cause the helpful error messages from the configure failure to scroll away.

fix sum moar typos [error messages]

2011-06-23T22:59:03Z

Various typo fixes in error messages within the source code. Signed-off-by: Pieter Praet Edited-by: Carl Worth Restricted to just error messages.

fix sum moar typos [user-visible documentation in code]

2011-06-23T22:58:50Z

Various typo fixes in documentation within the code that can be made available to the user, (emacs function help strings, "notmuch help" output, notmuch man page, etc.). Signed-off-by: Pieter Praet Edited-by: Carl Worth Restricted to just documentation and fixed fix of "comman" to "common" rather than "command".

fix sum moar typos [comments in source code]

2011-06-23T22:58:39Z

Various typo fixes in comments within the source code. Signed-off-by: Pieter Praet Edited-by: Carl Worth Restricted to just source-code comments, (and fixed fix of "descriptios" to "descriptors" rather than "descriptions").

fix sum moar typos [build scripts, Makefiles]

2011-06-23T22:44:59Z

Various typo fixes in comments within the Makefile and other build scripts. Signed-off-by: Pieter Praet Edited-by: Carl Worth Restricted to just build files.

Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup'

2011-06-23T22:19:06Z

This error occurs when `notmuch-fcc-dirs' is set to a list. The error was in the `notmuch-fcc-dirs' format check which was changed in an incompatible way from 0.4 to 0.5. The fix was extracted from a bigger patch series by David Edmondson id:"1290682750-30283-2-git-send-email-dme@dme.org". Signed-off-by: Jameson Graef Rollins

emacs: Show all multipart/alternative parts by default.

2011-06-23T01:28:12Z

This is patch is a temporary work-around for a slight regression that popped up in the part handling reorganization. Currently, text/plain parts are always preferred, if present, over other non-text/plain parts in multipart/alternative. However, this means that if there is a blank text/plain part, no content will be displayed. One way to get around this is to set the "notmuch-show-all-multipart/alternative-parts" customization variable to True ('t'), which will cause all parts to always be displayed. Since we want to move forward with the next release, we're going to set this variable true by default, to make sure that no content is unretrievably hidden from the user. Once we come up with a better solution for easy display of hidden parts we can set this back to a default value of 'nil'.

Simplify message and headers visibility code in notmuch-show view.

2011-06-15T14:07:32Z

Before the change, headers and message visibility functions took extra care to correctly set `buffer-invisibility-spec'. This was needed because headers overlay `invisible' property had only headers' invisibility spec. So visibility of headers was determined only by the headers invisibility spec. The patch sets headers overlay `invisible' property a list with both the headers and the message invisibility spec. This makes headers invisible if either of them is added to the `buffer-invisibility-spec' and allows to simplify the code.

Set higher priority for headers and hidden citation overlays.

2011-06-15T14:07:32Z

Before the patch, message, headers and hidden citation overlays had zero priority. All these overlay have `invisible' property. Emacs documentation says that we should not make assumptions about which overlay will prevail when they have the same priority [1]. It happens to work as we need, but we should not rely on undocumented behavior. [1] http://www.gnu.org/s/emacs/manual/html_node/elisp/Overlay-Properties.html