notmuch/gmime-filter-reply.c, branch nmweb

CLI: centralize initialization in notmuch_client_init

2021-05-14T09:40:37Z

Initially make sure gmime_filter_reply initialization is thread-safe (assuming notmuch_client_init is only called once). For tidyness, also put talloc initialization in the new function.

cli: run uncrustify

2019-06-14T10:41:27Z

This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory

index: explicitly follow GObject conventions

2018-10-21T13:21:26Z

Use explicit labels for GTypeInfo member initializers, rather than relying on comments and ordering. This is both easier to read, and harder to screw up. This also makes it clear that we're mis-casting GObject class initializers for gcc. Without this patch, g++ 8.2.0-7 produces this warning: CXX -g -O2 lib/index.o lib/index.cc: In function ‘GMimeFilter* notmuch_filter_discard_non_term_new(GMimeContentType*)’: lib/index.cc:252:23: warning: cast between incompatible function types from ‘void (*)(NotmuchFilterDiscardNonTermClass*)’ {aka ‘void (*)(_NotmuchFilterDiscardNonTermClass*)’} to ‘GClassInitFunc’ {aka ‘void (*)(void*, void*)’} [-Wcast-function-type] (GClassInitFunc) notmuch_filter_discard_non_term_class_init, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The definition of GClassInitFunc in /usr/include/glib-2.0/gobject/gtype.h suggests that this function will always be called with the class_data member of the GTypeInfo. We set that value to NULL in both GObject definitions in notmuch. So we mark it as explicitly unused. There is no functional change here, just code cleanup.

drop use of register keyword

2018-05-15T01:18:05Z

The performance benefits are dubious, and it's deprecated in C++11.

cli: convert notmuch_bool_t to stdbool

2017-10-10T01:24:02Z

C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the cli and test binaries to stdbool.

lib&cli: use g_object_new instead of g_object_newv

2017-09-04T11:04:44Z

'g_object_newv' is deprecated, and prints annoying warnings. The warnings suggest using 'g_object_new_with_properties', but that's only available since glib 2.55 (i.e. a month ago as of this writing). Since we don't actuall pass any properties, it seems we can just call 'g_object_new'.

Filter out carriage-returns in show and reply output.

2009-11-18T22:34:43Z

Thanks, windows mail clients. Signed-off-by: Keith Packard

notmuch reply: Add (incomplete) reply command

2009-11-10T21:32:02Z

Reviewed-by: Carl Worth Keith wrote all the code here against notmuch before notmuch.c was split up into multiple files. So I've pushed the code around in various ways to match the new code structure, but have generally tried to avoid making any changes to the behavior of the code. I did fix one bug---a missing call to g_mime_stream_file_set_owner in show_part which would cause "notmuch show" to go off into the weeds when trying to show multiple messages, (since the first stream would fclose stdout).