notmuch/lib/config.cc, branch 0.32.1 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.32.1 2021-05-10T14:12:58Z lib/config: expand relative paths when reading from database 2021-05-10T14:12:58Z David Bremner david@tethera.net 2021-05-07T10:27:37Z urn:sha1:1040e7aa077197e5295180ef54576ea39c298a36 This makes the treatment of relative paths consistent between the database and config files. lib/config: canonicalize paths relative to $HOME. 2021-05-10T14:08:18Z David Bremner david@tethera.net 2021-05-07T00:16:38Z urn:sha1:31098c4ae40511ffda9788a6654adbf898063d7f Prior to 0.32, notmuch had the (undocumented) behaviour that it expanded a relative value of database.path with respect to $HOME. In 0.32 this was special cased for database.path but broken for database.mail_root, which causes problems for at least notmuch-new when database.path is set to a relative path. The change in T030-config.sh reflects a user visible, but hopefully harmless behaviour change; the expanded form of the paths will now be printed by notmuch config. lib/config: remove early free in _get_email_from_passwd_file 2021-04-24T15:11:45Z David Bremner david@tethera.net 2021-04-24T13:44:28Z urn:sha1:5f80e106d6f6e695677527b509164a6e5194abd1 This (obvious) bug was caused by cut&pasting the code from notmuch-config.c into the library and adding on a return at the end. lib: provide notmuch_config_path 2021-03-27T12:26:14Z David Bremner david@tethera.net 2021-02-21T11:34:52Z urn:sha1:f5d4349921ded021756d6754d347420e68b23111 Since the library searches in several locations for a config file, the caller does not know which of these is chosen in the usual case of passing NULL as a config file. This changes provides an API for the caller to retrieve the name of the config file chosen. It will be tested in a following commit. CLI/config: migrate notmuch_config_open to new config 2021-03-27T12:26:14Z David Bremner david@tethera.net 2021-02-14T13:32:41Z urn:sha1:b76da87d29b6c9714e3d62fd8d459733df084f92 notmuch_config_open will be preserved in the medium term for use by the commands that are manipulating the config file directly (config and setup) lib/config: set default for primary user email 2021-03-27T12:26:14Z David Bremner david@tethera.net 2021-02-14T13:55:42Z urn:sha1:2e9ee47072e161e85d2ac60515d1c922ea881e40 This is mainly copying code from the CLI into the lib. The CLI copy will be deleted in a later commit. lib/config: set defaults for user full name 2021-03-27T12:26:14Z David Bremner david@tethera.net 2021-02-14T13:23:44Z urn:sha1:e81dc2072f22996a07e82b9b9b2eac826410e5a7 This just copies code from from the CLI into the library. New test infrastructure is needed because apparently we have never tested this code path. lib/config: add config_pairs iterators 2021-03-27T12:26:14Z David Bremner david@tethera.net 2021-02-14T11:42:58Z urn:sha1:863b2431853385441f9fcbc22b9ff4e963091440 The layer of shims here seems a bit wasteful compared to just calling the corresponding string map functions directly, but it allows control over the API (calling with notmuch_database_t *) and flexibility for future changes. lib/config: add notmuch_config_get_values_string 2021-03-27T12:26:14Z David Bremner david@tethera.net 2021-02-13T17:17:52Z urn:sha1:0c6db22930b58fcea972e71b45f7ea0e6055ed20 This is to support the less common (at least in the notmuch codebase) case of accessing a ;-delimited list config value with an arbitrary string key. lib/config: add configuration variable for backup directory 2021-03-20T10:51:36Z David Bremner david@tethera.net 2021-02-17T15:04:54Z urn:sha1:a7873df331bcd53dd1bc8da95c4279163437cc13 Like the hook directory, we primarily need a way to communicate this directory between various components, but we may as well let the user configure it. Most of the diff is generalizing choose_hook_dir to work for both backup and hook directories.