notmuch/lib/database.cc, branch 0.22

lib: clean up _notmuch_database_split_path

2016-04-12T23:46:42Z

Make the logic it a bit easier to read. No functional changes.

lib: fix handling of one character long directory names at top level

2016-04-12T23:40:19Z

The code to skip multiple slashes in _notmuch_database_split_path() skips back one character too much. This is compensated by a +1 in the length parameter to the strndup() call. Mostly this works fine, but if the path is to a file under a top level directory with one character long name, the directory part is mistaken to be part of the file name (slash == path in code). The returned directory name will be the empty string and the basename will be the full path, breaking the indexing logic in notmuch new. Fix the multiple slash skipping to keep the slash variable pointing at the last slash, and adjust strndup() accordingly. The bug was introduced in commit e890b0cf4011fd9fd77ebd87343379e4a778888b Author: Carl Worth Date: Sat Dec 19 13:20:26 2009 -0800 database: Store the parent ID for each directory document. just a little over two months after the initial commit in the Notmuch code history, making this the longest living bug in Notmuch to date.

forbid atomic transactions on writable, upgradable databases

2015-11-23T12:15:37Z

We can't (but currently do) allow upgrades within transactions because upgrades need their own transactions. We don't want to re-use the current transaction because bailing out of an upgrade would mean loosing all previous changes (because our "atomic" transactions don't commit before hand). This gives us two options: 1. Fail at the beginning of upgrade (tell the user to end the transaction, upgrade, and start over). 2. Don't allow the user to start the transaction. I went with the latter because: 1. There is no reason to call `begin_atomic` unless you intend to to write to the database and anyone intending to write to the database should upgrade it first. 2. This means that nothing inside an atomic transaction can ever fail with NOTMUCH_STATUS_UPGRADE_REQUIRED.

lib: migrate notmuch_database_upgrade to new query_search API

2015-10-05T22:53:11Z

Here we depend on the error path cleaning up query

lib: add versions of n_q_count_{message,threads} with status return

2015-10-05T22:44:07Z

Although I think it's a pretty bad idea to continue using the old API, this allows both a more gentle transition for clients of the library, and allows us to break one monolithic change into a series

lib: move query variable to function scope

2015-10-05T22:39:11Z

This is a prelude to deallocating it (if necessary) on the error path.

lib: constify argument to notmuch_database_status_string

2015-09-04T11:24:38Z

We don't modify the database struct, so no harm in committing to that.

lib: note remaining uses of deprecated message search API

2015-09-04T11:08:18Z

The two remaining cases in the lib seem to require more than a simple replacement of the old call, with the new call plus a check of the return value.

lib: Add "lastmod:" queries for filtering by last modification

2015-08-14T16:23:49Z

The implementation is essentially the same as the date range search prior to Jani's fancy date parser.

lib: API to retrieve database revision and UUID

2015-08-13T21:52:51Z

This exposes the committed database revision to library users along with a UUID that can be used to detect when revision numbers are no longer comparable (e.g., because the database has been replaced).