notmuch/lib/database.cc, branch 0.3

lib: Audit all notmuch_database call for Xapian exception handling.

2010-04-24T14:27:50Z

Our current approach is for top-level entry poitns in the library to have try/catch blocks that catch any Xapian exception and print a message. Add a few missing blocks and fix up the documentation.

lib: Remove condition regarding a NULL parent_thread_id.

2010-04-12T22:54:03Z

A recent change guaranteed that a message ID can never be resolved to a NULL thread ID, so we don't need this extra case.

lib: Always add reference terms to the database.

2010-04-12T22:45:40Z

Previously, we were only adding the reference terms for cases where the referenced message did not yet exist in the database. For thread presentation, it's useful to have the connection information provided by the references, even when the messages are present. So add this term unconditionally.

lib: Document the metadata stored within the Xapian database.

2010-04-12T22:15:14Z

We are currently storing "version", "last_thread_id", and "thread_id_*" values so document how each of these are used.

lib: Fix line-wrapping in _notmuch_database_link_message.

2010-04-12T21:41:34Z

This function had some excessively long lines due to nested expressions. It's simple enough to un-nest these and have readable line lengths.

lib: Fix internal documentation of _notmuch_database_link_message

2010-04-12T21:35:25Z

This function was recently modified, (to include a metadata lookup for a message's thread ID before looking for parent/child thread IDs), but the documentation wasn't updated. Fix that.

lib: Simplify code flow in _resolve_message_id_to_thread_id

2010-04-12T21:29:36Z

There are two primary cases in this function, (the message exists in the database or it does not). Previously the code for these two cases was split and intermingled with goto-spaghetti connections.

lib: Fix internal documentation of _resolve_message_id_to_thread_id

2010-04-12T21:19:15Z

We no longer return NULL, but instead generate a new thread ID for messages that we haven't seen yet.

Store thread ids for messages that we haven't seen yet

2010-04-12T21:11:57Z

This allows us to thread messages even when we receive them out of order, or never receive the root. The thread ids for messages that aren't present but are referred to are stored as metadata in the database and then retrieved if we ever get that message. When determining the thread id for a message we also check for this metadata so that we can thread descendants of a message together before we receive it. Edited by Carl Worth : Split this portion of the commit from the earlier-applied portion adding test cases.

Add is: as a synonym for tag: in search terms.

2010-03-10T00:03:58Z

I like the readability of this, it provides compatibility with people trained in this syntax by sup, and it even saves one character.