notmuch/lib/database.cc, branch 0.4

lib: Eliminate some redundant includes of xapian.h

2010-11-02T06:24:40Z

Most files including this already include database-private.h which includes xapian.h already.

lib: Add some missing static qualifiers.

2010-11-02T04:58:43Z

These various functions and data are all used only locally, so should be marked static. Ensuring we get these right will avoid us accidentally leaking unintended symbols through the library interface.

lib: Fix use-after-free bug.

2010-09-20T22:01:52Z

Thanks to the new git-based test suite, it's easy to run the whole test suite in valgrind, (simply "make test OPTIONS="--valgrind"), and doing so showed this obvious use-after-free bug, (triggered by the thread-order tests).

Add support (and tests) for messages with really long message IDs.

2010-06-04T20:35:07Z

Scott Henson reported an internal error that occurred when he tried to add a message that referenced another message with a message ID well over 300 characters in length. The bug here was running into a Xapian limit for the length of metadata key names, (which is even more restrictive than the Xapian limit for the length of terms). We fix this by noticing long message ID values and instead using a message ID of the form "notmuch-sha1-". That is, we use SHA1 to generate a compressed, (but still unique), version of the message ID. We add support to the test suite to exercise this fix. The tests add a message referencing the long message ID, then add the message with the long message ID, then finally add another message referencing the long ID. Each of these tests exercise different code paths where the special handling is implemented. A final test ensures that all three messages are stitched together into a single thread---guaranteeing that the three code paths all act consistently.

Avoid database corruption by not adding partially-constructed mail documents.

2010-06-04T17:16:53Z

Previously we were using Xapian's add_document to allocate document ID values for notmuch_message_t objects. This had the drawback of adding a partially constructed mail document to the database. If notmuch was subsequently interrupted before fully populating this document, then later runs would be quite confused when seeing the partial documents. There are reports from the wild of people hitting internal errors of the form "Message ... has no thread ID" for example, (which is currently an unrecoverable error). We fix this by manually allocating document IDs without adding documents. With this change, we never call Xapian's add_document method, but only replace_document with either the current document ID of a message or a new one that we have allocated.

lib: Audit all notmuch_database call for Xapian exception handling.

2010-04-24T14:27:50Z

Our current approach is for top-level entry poitns in the library to have try/catch blocks that catch any Xapian exception and print a message. Add a few missing blocks and fix up the documentation.

lib: Remove condition regarding a NULL parent_thread_id.

2010-04-12T22:54:03Z

A recent change guaranteed that a message ID can never be resolved to a NULL thread ID, so we don't need this extra case.

lib: Always add reference terms to the database.

2010-04-12T22:45:40Z

Previously, we were only adding the reference terms for cases where the referenced message did not yet exist in the database. For thread presentation, it's useful to have the connection information provided by the references, even when the messages are present. So add this term unconditionally.

lib: Document the metadata stored within the Xapian database.

2010-04-12T22:15:14Z

We are currently storing "version", "last_thread_id", and "thread_id_*" values so document how each of these are used.

lib: Fix line-wrapping in _notmuch_database_link_message.

2010-04-12T21:41:34Z

This function had some excessively long lines due to nested expressions. It's simple enough to un-nest these and have readable line lengths.