notmuch/lib/database.cc, branch 0.40

lib: return NOTMUCH_STATUS_OPERATION_INVALIDATED where appropriate

2025-08-09T10:12:23Z

The overall goal is to allow clients to restart operations in situations where that is the response recommended by the underlying Xapian library. Amended-by: db, added above explanation

lib: handle DatabaseModifiedError in _notmuch_message_create

2025-07-24T10:30:58Z

If an open database is modified sufficiently by other callers, the open instance becomes invalid and operations on it throw DatabaseModifiedError. Per Xapian documentation, the caller is then supposed to reopen the database and restart the query. This exception is currently not handled in _notmuch_message_create(), leading to the default handler abort()ing the process. Catch this exception in _notmuch_message_create() and return an error instead of crashing. Since the entire query becomes invalid - including results that have already been read by the caller - this situation cannot be handled by libnotmuch transparently. A new public function - notmuch_messages_status() - is added to allow the callers to check whether the messages iterator was exhausted or terminated early due to a runtime error. This also allows memory allocation failure to be signalled to the caller. Amended-By: David Bremner [replace use of notmuch_messages_valid]

lib/n_d_remove_message: do not remove unique filename

2023-07-22T10:15:59Z

It is wasteful to remove a filename term when the whole message document is about to be removed from the database. Profiling with perf shows this takes a significant portion of the time when cleaning up removed files in the database. The logic of n_d_remove_message becomes a bit more convoluted here in order to make the change minimal. It is possible that this function can be further optimized, since the expansion of filename terms into filenames is probably not needed here.

lib: index attachments with mime types matching index.as_text

2023-04-02T22:24:43Z

Instead of skipping indexing all attachments, we check of a (user configured) mime type that is indexable as text.

lib/database: propagate status code from _notmuch_message_delete

2022-12-27T15:59:29Z

_notmuch_message_delete can return (at least) NOTMUCH_STATUS_XAPIAN_EXCEPTION, which we should not ignore.

lib: add NOTMUCH_STATUS_CLOSED_DATABASE, use in _n_d_ensure_writable

2022-06-25T19:06:18Z

In order for a database to actually be writeable, it must be the case that it is open, not just the correct type of Xapian object. By explicitely checking, we are able to provide better error reporting, in particular for the previously broken test in T566-lib-message.

lib/database: delete stemmer on destroy

2022-01-23T01:14:29Z

Commit [0] left the stemmer object accessible, but did not add de-allocation code to notmuch_database_destroy. This commit corrects that oversight. Leak originally reported by Austin Ray [1]. [0]: 3202e0d1feba1ab955ba1c07098c00208f8f0ada [1]: id:20220105224538.m36lnjn7rf3ieonc@athena

lib/open: no default mail root in split configurations

2022-01-15T19:59:39Z

If we know the configuration is split, but there is no mail root defined, this indicates a (lack of) configuration error. Currently this can only arise in XDG configurations.

lib/compact: replace deprecated notmuch_database_open_verbose

2021-10-30T18:04:00Z

It should not be necesary to have any config information here, hence passing "" to n_d_open_with_config.

lib: add new status code for query syntax errors.

2021-09-05T00:07:19Z

This will help provide more meaningful error messages without special casing on the client side.