notmuch/lib/database.cc, branch debian/0.12_rc2-1

Fix error reporting in notmuch_database_find_message_by_filename

2012-03-18T10:58:35Z

Formerly it was possible for *message_ret to be left uninitialized. The documentation however clearly states that "[o]n any failure or when the message is not found, this function initializes '*message' to NULL". Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

Actually close the xapian database in notmuch_database_close

2012-03-03T15:30:07Z

Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated lock is released immediately. The comment is a courtesy of Austin Clements. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

Prevent segmentation fault in notmuch_database_close

2012-02-21T03:03:25Z

Previously opening a notmuch database in read write mode that has been locked resulted in the notmuch_database_open function executing notmuch_database_close as a cleanup function. notmuch_database_close failed to check whether the xapian database has in fact been created. Add a check whether the xapian database object has actually been created before trying to call its flush method. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

lib: Use talloc to simplify cleanup in notmuch_database_open

2012-02-04T01:15:45Z

Previously, we manually "free"d various pointers in notmuch_database_open. Use a local talloc context instead to simplify cleanup and eliminate various NULL pointer initializations and conditionals.

lib: Release resources if notmuch_database_open fails

2012-02-04T01:15:26Z

Previously, if a Xapian exception occurred in notmuch_database_open, we failed to clean up the allocated notmuch_database_t object.

lib: Don't delete uninitialized pointers

2012-02-04T01:14:59Z

In the error-handling paths of notmuch_database_open, we call notmuch_database_close, which "delete"s several objects referenced by the notmuch_database_t object. However, some of these pointers may be uninitialized, resulting in undefined behavior. Hence, allocate the notmuch_database_t with talloc_zero to make sure these pointers are NULL so that "delete"ing them is harmless.

lib: call g_mime_init() from notmuch_database_open()

2012-01-01T03:08:15Z

As reported in id:"CAEbOPGyuHnz4BPtDutnTPUHcP3eYcRCRkXhYoJR43RUMw671+g@mail.gmail.com" sometimes gmime tries to access a NULL pointer, e.g. g_mime_iconv_open() tries to access iconv_cache that is NULL if g_mime_init() is not called. This causes notmuch to segfault when calling gmime functions. Calling g_mime_init() initializes iconv_cache and others variables needed by gmime, making sure they are initialized when notmuch calls gmime functions. Test marked fix by db.

Fix comments about what is stored in the database

2011-12-23T19:08:34Z

Commit 567bcbc2 introduced two new values for each message (content of the "From" and "Subject" headers), but the comments about the database schema had not been updated accordingly.

notmuch: Quiet buildbot warnings.

2011-12-21T11:32:16Z

Cast away the result of various *write functions. Provide a default value for some variables to avoid "use before set" warnings.

lib: call g_type_init from notmuch_database_open

2011-12-05T02:00:25Z

We want to make sure g_type_init is called before any GObject functionality is used.