notmuch/lib/database.cc, branch debian/0.17-2 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=debian%2F0.17-2 2013-11-20T00:15:02Z compact: improve error messages on failures after compaction 2013-11-20T00:15:02Z Tomi Ollila tomi.ollila@iki.fi 2013-11-14T22:03:27Z urn:sha1:2fd7ef64baf02892a7bebfb57d593afb086145ef The error messages written during the steps replacing old database with new now includes relevant paths and strerror. compact: unconditionally remove old wip database compact directory 2013-11-20T00:14:28Z Tomi Ollila tomi.ollila@iki.fi 2013-11-14T22:03:26Z urn:sha1:6452ae0fcb0a2ee45a47144da71a6de9d8dace2c In case previous notmuch compact has been interrupted there is old work-in-progress database compact directory partially filled. Remove it just before starting to fill the directory with new files. compact: preserve backup database until compacted database is in place 2013-11-20T00:13:25Z Tomi Ollila tomi.ollila@iki.fi 2013-11-14T22:03:25Z urn:sha1:cb6cc296e27fdab85faa4bdd670eda2e0c53b8c2 It is less error prone and window of failure opportunity is smaller if the old (backup) database is always renamed (instead of sometimes rmtree'd) before new (compacted) database is put into its place. Finally rmtree() old database in case old database backup is not kept. compact: catch Xapian::Error consistently 2013-11-18T00:25:43Z Tomi Ollila tomi.ollila@iki.fi 2013-11-13T17:02:44Z urn:sha1:19a89753ca20b269a131e747238925cce254c627 catch Xapian::Error in compact code in lib/database.cc to be consistent with other code in addition to not making software crash on uncaught other Xapian error. compact: tidy formatting 2013-11-18T00:25:25Z Tomi Ollila tomi.ollila@iki.fi 2013-11-13T17:02:43Z urn:sha1:4d5986e8ad671c1f5504894af6fbe37ba314bed8 Notmuch compact code whitespace changes to match devel/STYLE. lib: use the compaction backup path provided by the caller 2013-11-07T10:51:16Z Jani Nikula jani@nikula.org 2013-11-03T12:24:47Z urn:sha1:00d2ac2b41a6dba060837244ee87edce2fd1e465 The extra path component added by the lib is a magic value that the caller just has to know. This is demonstrated by the current code, which indeed has "xapian.old" both sides of the interface. Use the backup path provided by the lib caller verbatim, without adding anything to it. lib: add closure parameter to compact status update callback 2013-11-07T10:46:42Z Jani Nikula jani@nikula.org 2013-11-03T12:24:45Z urn:sha1:180dba66e47a5257b2cdf2f1ceb59cc8fa5a69d4 This provides much more flexibility for the caller. lib: do not leak the database in compaction 2013-11-07T10:46:25Z Jani Nikula jani@nikula.org 2013-11-03T12:24:44Z urn:sha1:35ca5feb28a6e52851ba61ea63478ade40991558 Destroy instead of close the database after compaction, and also on error path, to not leak the database. lib: check talloc success in compact 2013-11-06T21:49:46Z Jani Nikula jani@nikula.org 2013-11-03T12:24:43Z urn:sha1:a95dbba1562a4685c73f86fb30380e6663cae894 In line with the allocation checks all around. lib: construct compactor within try block to catch any exceptions 2013-11-06T21:49:36Z Jani Nikula jani@nikula.org 2013-11-03T12:24:42Z urn:sha1:8e4e537ceefec51fc811d0be3027572a904ba38c Constructors may also throw exceptions. Catch them.