thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=master 2017-05-12T10:17:18Z 2017-05-12T10:17:18Z Jani Nikula jani@nikula.org 2017-05-10T19:42:11Z urn:sha1:bc11759dd1fd198661657b741bc0143c9af309a4 The dynamic generation of the linker version script for libnotmuch exports has grown rather complicated. Reverse the visibility control by hiding symbols by default using -fvisibility=hidden, and explicitly exporting symbols in notmuch.h using #pragma GCC visibility. (We could also use __attribute__ ((visibility ("default"))) for each exported function, but the pragma is more convenient.) The above is not quite enough alone, as it would "leak" a number of weak symbols from Xapian and C++ standard library. Combine it with a small static version script that filters out everything except the notmuch_* symbols that we explicitly exposed, and the C++ RTTI typeinfo symbols for exception handling. Finally, as the symbol hiding test can no longer look at the generated symbol table, switch the test to parse the functions from notmuch.h. 2017-05-11T23:41:10Z Jani Nikula jani@nikula.org 2017-05-10T19:42:09Z urn:sha1:d5ed9af0e42c0f32bcababd6ac5ce42ccb1bf283 Commits 9db214527213 ("lib/gen-version-script.h: add getline and getdelim to notmuch.sym if needed") and 3242e29e57ac ("build: add canonicalize_file_name to symbols exported from libnotmuch.so") started exporting compat functions from libnotmuch so that the cli could use them. But we shouldn't export such functions from the library. They are not part of our ABI. Instead, the cli should include its own copies of the compat functions. 2016-06-05T11:32:17Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2016-06-02T16:26:14Z urn:sha1:6a833a6e83865f6999707cc30768d07e1351c2cb Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests. 2016-06-05T11:23:28Z Tomi Ollila tomi.ollila@iki.fi 2016-05-28T17:45:31Z urn:sha1:cf09631a45d276826255d197c1d5c913a29c79f4 Cleaned the following whitespace in lib/* files: lib/index.cc: 1 line: trailing whitespace lib/database.cc 5 lines: 8 spaces at the beginning of line lib/notmuch-private.h: 4 lines: 8 spaces at the beginning of line lib/message.cc: 1 line: trailing whitespace lib/sha1.c: 1 line: empty lines at the end of file lib/query.cc: 2 lines: 8 spaces at the beginning of line lib/gen-version-script.sh: 1 line: trailing whitespace 2015-07-28T19:34:01Z David Bremner david@tethera.net 2015-07-27T18:42:32Z urn:sha1:882ccb7e49fa8cca9d498c3eda0fbb64ea57d348 It turns out that on certain systems like FreeBSD, c++filt is not installed by default. It's basically OK if we fail the build in that case, but what's really not OK is for the build to continue and generate bad binaries. 2014-04-18T20:58:34Z David Bremner david@tethera.net 2014-04-09T11:24:02Z urn:sha1:3242e29e57acf1715f4f7bfd7c384d4a699c68f3 This is needed for our compat version of canonicalize_file_name to be used. 2011-09-05T10:44:14Z David Bremner bremner@debian.org 2011-09-05T03:19:32Z urn:sha1:9db21452721356be5169254cd7e8c0ec5b25066b If the configure script detects missing getline and/or getdelim symbols, then notmuch will use it's own versions. This patch, based on id:"87k49v12i5.fsf@pc44es141.cs.uni-magdeburg.de" by Matthias Guedemann, adds the symbols to notmuch.sym as well so they are properly exported from the library. 2011-09-05T10:39:44Z David Bremner bremner@debian.org 2011-09-05T02:50:36Z urn:sha1:80212b13294cababfb41f643765ca00bdf8e55dd OpenBSD nm apparently doesn't support --defined. The awk condition is based on the assumption that all defined symbols have some hex number in the first column. Thanks to Matthias Guedemann reporting the problem, and an earlier version of this patch. 2011-08-21T19:50:39Z David Bremner bremner@debian.org 2011-08-21T19:45:00Z urn:sha1:4b55df85348c4ad4129bf6a9af052231f1d6716e Unfortunately Robin Green's patch 52e4dedf9aa was lost when I created gen-version-script.sh. This merges his changes manually into that script. It turns out tabs seem not needed in version script files, so I simplified a bit and removed the printf. Thanks to Alexander Botero-Lowry for help and testing. 2011-07-17T01:16:46Z David Bremner bremner@debian.org 2011-07-16T18:59:44Z urn:sha1:feb22fef2e3f6f1cf1722f00945c580e506df0df The lack of such exporting seems to cause problems catching exceptions, as suggested by http://gcc.gnu.org/wiki/Visibility This manifested in the symbol-hiding test failing when notmuch was compile with gcc 4.4.5. On i386, this further manifested as notmuch new failing to run (crashing with an uncaught exception on first run).