notmuch/lib/index.cc, branch 0.29.1

indexing: record protected subject when indexing cleartext

2019-05-29T11:14:44Z

When indexing the cleartext of an encrypted message, record any protected subject in the database, which should make it findable and visible in search. Signed-off-by: Daniel Kahn Gillmor

lib/database: index user headers.

2019-05-25T10:21:13Z

This essentially involves calling _notmuch_message_gen_terms once for each user defined header.

gmime-cleanup: use GMime 3.0 function names

2019-05-03T09:57:16Z

Signed-off-by: Daniel Kahn Gillmor

gmime-cleanup: drop all arguments unused in GMime 3

2019-05-03T09:56:38Z

This means dropping GMimeCryptoContext and notmuch_config arguments. All the argument changes are to internal functions, so this is not an API or ABI break. We also get to drop the #define for g_mime_3_unused. signed-off-by: Daniel Kahn Gillmor

gmime-cleanup: drop g_mime_2_6_unref

2019-05-03T09:56:28Z

signed-off-by: Daniel Kahn Gillmor

gmime-cleanup: always support session keys

2019-05-03T09:55:32Z

Our minimum version of GMime 3.0 always supports good session key handling. signed-off-by: Daniel Kahn Gillmor

gmime-cleanup: drop unused gmime 2.6 content_type from _index_encrypted_mime_part

2019-05-03T09:50:27Z

In _index_mime_part, we don't need to extract the content-type from the part until just before we use it, so we also defer it lazily. Signed-off-by: Daniel Kahn Gillmor

index: explicitly follow GObject conventions

2018-10-21T13:21:26Z

Use explicit labels for GTypeInfo member initializers, rather than relying on comments and ordering. This is both easier to read, and harder to screw up. This also makes it clear that we're mis-casting GObject class initializers for gcc. Without this patch, g++ 8.2.0-7 produces this warning: CXX -g -O2 lib/index.o lib/index.cc: In function ‘GMimeFilter* notmuch_filter_discard_non_term_new(GMimeContentType*)’: lib/index.cc:252:23: warning: cast between incompatible function types from ‘void (*)(NotmuchFilterDiscardNonTermClass*)’ {aka ‘void (*)(_NotmuchFilterDiscardNonTermClass*)’} to ‘GClassInitFunc’ {aka ‘void (*)(void*, void*)’} [-Wcast-function-type] (GClassInitFunc) notmuch_filter_discard_non_term_class_init, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The definition of GClassInitFunc in /usr/include/glib-2.0/gobject/gtype.h suggests that this function will always be called with the class_data member of the GTypeInfo. We set that value to NULL in both GObject definitions in notmuch. So we mark it as explicitly unused. There is no functional change here, just code cleanup.

lib: expose notmuch_message_get_database()

2018-05-26T14:30:32Z

We've had _notmuch_message_database() internally for a while, and it's useful. It turns out to be useful on the other side of the library interface as well (i'll use it later in this series for "notmuch show"), so we expose it publicly now.

drop use of register keyword

2018-05-15T01:18:05Z

The performance benefits are dubious, and it's deprecated in C++11.