notmuch/lib/message-file.c, branch 0.29

lib/message-file: close stream in destructor

2019-05-10T15:26:50Z

Without this, $ make time-test OPTIONS=--small leads to fatal errors from too many open files. Thanks to st-gourichon-fid for bringing this problem to my attention in IRC.

lib/message_file: open gzipped files

2019-05-03T10:48:43Z

Rather than storing the lower level stdio FILE object, we store a GMime stream. This allows both transparent decompression, and passing the stream into GMime for parsing. As a side effect, we can let GMime close the underlying OS stream (indeed, that stream isn't visible here anymore). This change is enough to get notmuch-{new,search} working, but there is still some work required for notmuch-show, to be done in a following commit.

gmime-cleanup: pass NULL as default GMimeParserOptions

2019-05-03T09:58:00Z

This is a functional change, not a straight translation, because we are no longer directly invoking g_mime_parser_options_get_default(), but the GMime source has indicated that the options parameter for g_mime_parser_construct_message() is "nullable" since upstream commit d0ebdd2ea3e6fa635a2a551c846e9bc8b6040353 (which itself precedes GMime 3.0). Signed-off-by: Daniel Kahn Gillmor

gmime-cleanup: pass NULL arguments explicitly where GMime 3.0 expects it

2019-05-03T09:57:27Z

Several GMime 2.6 functions sprouted a change in the argument order in GMime 3.0. We had a compatibility layer here to be able to handle compiling against both GMime 2.6 and 3.0. Now that we're using 3.0 only, rip out the compatibility layer for those functions with changed argument lists, and explicitly use the 3.0 argument lists. Signed-off-by: Daniel Kahn Gillmor

gmime-cleanup: drop unused gmime #defines and simplify g_mime_init ()

2019-05-03T09:56:58Z

Several of these #defines were not actually used in the notmuch codebase any longer. And as of GMime 3.0, g_mime_init takes no arguments, so we can also drop the bogus RFC2047 argument that we were passing and then #defining away. signed-off-by: Daniel Kahn Gillmor

gmime-cleanup: remove GMime 2.6 variant codeblocks

2019-05-03T09:50:40Z

signed-off-by: Daniel Kahn Gillmor

lib: convert notmuch_bool_t to stdbool internally

2017-10-10T01:27:16Z

C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the lib internally to stdbool.

lib: refactor notmuch_database_add_message header parsing

2017-08-02T01:17:47Z

This function is large and hard to understand and modify. Start to break it down into meaningful pieces.

lib: add version of _n_m_f_get_combinded_header for gmime 3.0

2017-07-15T00:23:52Z

The iterator is gone, so we need a new loop structure.

lib: refactor _notmuch_messsage_file_get_combined_header

2017-07-15T00:23:52Z

We need to rewrite the loop for gmime-3.0; move the loop body to its own function to avoid code duplication. Keep the common exit via "goto DONE" to make this pure code movement. It's important to note that the existing exit path only deallocates the iterator.