notmuch/lib/message-file.c, branch debian/0.25-3

lib: add version of _n_m_f_get_combinded_header for gmime 3.0

2017-07-15T00:23:52Z

The iterator is gone, so we need a new loop structure.

lib: refactor _notmuch_messsage_file_get_combined_header

2017-07-15T00:23:52Z

We need to rewrite the loop for gmime-3.0; move the loop body to its own function to avoid code duplication. Keep the common exit via "goto DONE" to make this pure code movement. It's important to note that the existing exit path only deallocates the iterator.

Use https instead of http where possible

2016-06-05T11:32:17Z

Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.

util: move strcase_equal and strcase_hash to util

2015-09-07T12:43:31Z

For future use in both cli and lib.

lib: eliminate fprintf from _notmuch_message_file_open

2015-03-28T23:34:15Z

You may wonder why _notmuch_message_file_open_ctx has two parameters. This is because we need sometime to use a ctx which is a notmuch_message_t. While we could get the database from this, there is no easy way in C to tell type we are getting.

lib: drop the deprecation message for single-message mbox files

2015-01-01T15:47:47Z

We generally do not support mbox files, but for historical reasons we've supported single-message mbox files, with a deprecation message. We've tried dropping the support altogether, but backed out of it because we'd need to stop indexing them, while keeping support for previously indexed files. This would be more complicated than simply supporting single-message mbox files. Therefore, drop the deprecation message, and just silently accept single-message mboxes.

lib: Start all function names in notmuch-private.h with

2014-07-13T15:25:29Z

As noted in devel/STYLE, every private library function should start with _notmuch. This patch corrects function naming that did not adhere to this style in lib/notmuch-private.h. In particular, the old function names that now begin with _notmuch are notmuch_sha1_of_file notmuch_sha1_of_string notmuch_message_file_close notmuch_message_file_get_header notmuch_message_file_open notmuch_message_get_author notmuch_message_set_author Signed-off-by: Charles Celerier

lib: resurrect support for single-message mbox files

2014-06-14T01:59:04Z

This is effectively a revert of commit 6812136bf576d894591606d9e10096719054d1f9 Author: Jani Nikula Date: Mon Mar 31 00:21:48 2014 +0300 lib: drop support for single-message mbox files The intention was to drop support for indexing new single-message mbox files (and whether that was a good idea in the first place is arguable). However this inadvertently broke support for reading headers from previously indexed single-message mbox files, which is far worse. Distinguishing between the two cases would require more code than simply bringing back support for single-message mbox files.

lib: replace the header parser with gmime

2014-04-05T15:53:04Z

The notmuch library includes a full blown message header parser. Yet the same message headers are parsed by gmime during indexing. Switch to gmime parsing completely. These are the main changes: * Gmime stops header parsing at the first invalid header, and presumes the message body starts from there. The current parser is quite liberal in accepting broken headers. The change means we will be much pickier about accepting invalid messages. * The current parser converts tabs used in header folding to spaces. Gmime preserve the tabs. Due to a broken python library used in mailman, there are plenty of mailing lists that produce headers with tabs in header folding, and we'll see plenty of tabs. (This change has been mitigated in preparatory patches.) * For pure header parsing, the current parser is likely faster than gmime, which parses the whole message rather than just the headers. Since we parse the message and its headers using gmime for indexing anyway, this avoids and extra header parsing round when adding new messages. In case of duplicate messages, we'll end up parsing the full message although just headers would be sufficient. All in all this should still speed up 'notmuch new'. * Calls to notmuch_message_get_header() may be slightly slower than previously for headers that are not indexed in the database, due to parsing of the whole message. Within the notmuch code base, notmuch reply is the only such user.

lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init()

2013-09-14T17:13:43Z

As explained by Jeffrey Stedfast, the author of GMime, quoted in [1]: > Passing the GMIME_ENABLE_RFC2047_WORKAROUNDS flag to g_mime_init() > *should* solve the decoding problem mentioned in the thread. This > flag should be safe to pass into g_mime_init() without any bad side > effects and my unit tests do test that code-path. The thread being referred to is [2]. [1] id:87bo56viyo.fsf@nikula.org [2] id:08cb1dcd-c5db-4e33-8b09-7730cb3d59a2@gmail.com