notmuch/lib/message.cc, branch 0.19_rc2

lib: Internal support for querying and creating ghost messages

2014-10-25T17:26:54Z

This updates the message abstraction to support ghost messages: it adds a message flag that distinguishes regular messages from ghost messages, and an internal function for initializing a newly created (blank) message as a ghost message.

lib: Introduce macros for bit operations

2014-10-25T17:26:43Z

These macros help clarify basic bit-twiddling code and are written to be robust against C undefined behavior of shift operators.

lib: Handle empty date value

2014-10-11T05:10:12Z

In the interest of robustness, avoid undefined behavior of sortable_unserialise if the date value is missing. This shouldn't happen now, but ghost messages will have blank date values.

lib: Move message ID compression to _notmuch_message_create_for_message_id

2014-10-11T05:09:54Z

Previously, this was performed by notmuch_database_add_message. This happens to be the only caller currently (which is why this was safe), but we're about to introduce more callers, and it makes more sense to put responsibility for ID compression in the lower-level function rather than requiring each caller to handle it.

lib: actually return failures from notmuch_message_tags_to_maildir_flags

2014-09-24T18:19:34Z

The function takes great care to preserve the first error status it encounters, yet fails to return that status to the caller. Fix it.

lib: Return an error from operations that require an upgrade

2014-08-30T18:39:41Z

Previously, there was no protection against a caller invoking an operation on an old database version that would effectively corrupt the database by treating it like a newer version. According to notmuch.h, any caller that opens the database in read/write mode is supposed to check if the database needs upgrading and perform an upgrade if it does. This would protect against this, but nobody (even the CLI) actually does this. However, with features, it's easy to protect against incompatible operations on a fine-grained basis. This lightweight change allows callers to safely operate on old database versions, while preventing specific operations that would corrupt the database with an informative error message.

lib: Support empty header values in database

2014-08-30T18:37:33Z

Commit 567bcbc2 introduced support for storing various headers in document values. However, doing so in a backwards-compatible way meant that genuinely empty header values could not be distinguished from the old behavior of not storing the headers at all, so these required parsing the original message. Now that we have database features, new databases can declare that all messages have header values, so if we have this feature flag, we can use the stored header value even if it's the empty string. This requires slight cleanup to notmuch_message_get_header, since the code previously couldn't distinguish between empty headers and headers that are never stored in the database (previously this distinction didn't matter).

lib: Improve documentation of _notmuch_message_create_for_message_id

2014-08-05T11:14:15Z

Clarify the state of the returned message when _notmuch_message_create_for_message_id returns NOTMUCH_PRIVATE_STATUS_NO_DOCUMENT_FOUND.

lib: Invalidate message metadata in _notmuch_message_gen_terms

2014-08-04T21:57:55Z

Previously, we invalidated stored message metadata in _notmuch_message_add_term and _notmuch_message_remove_term, but not in _notmuch_message_gen_terms. This doesn't currently result in any bugs because of our limited uses of _notmuch_message_gen_terms, but it may could cause trouble in the future.

lib: Start all function names in notmuch-private.h with

2014-07-13T15:25:29Z

As noted in devel/STYLE, every private library function should start with _notmuch. This patch corrects function naming that did not adhere to this style in lib/notmuch-private.h. In particular, the old function names that now begin with _notmuch are notmuch_sha1_of_file notmuch_sha1_of_string notmuch_message_file_close notmuch_message_file_get_header notmuch_message_file_open notmuch_message_get_author notmuch_message_set_author Signed-off-by: Charles Celerier