notmuch/lib/message.cc, branch 0.31.1 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.31.1 2020-07-28T11:47:58Z lib: replace use of static_cast for writable databases 2020-07-28T11:47:58Z David Bremner david@tethera.net 2020-07-26T23:31:36Z urn:sha1:a09293793f43b93b7008dd361b192199ad528fca static_cast is a bit tricky to understand and error prone, so add a second pointer to (potentially the same) Xapian database object that we know has the right subclass. lib: encapsulate the use of notmuch_database_t field 'mode' 2020-07-28T11:47:58Z David Bremner david@tethera.net 2020-07-26T23:31:35Z urn:sha1:d7d4c729ab3b74eaaebe64cb8c7383b0ea06cec0 The plan is to change the underlying representation. lib: fix exception messages for n_m_message_* 2020-07-22T22:52:55Z David Bremner david@tethera.net 2020-07-22T11:19:28Z urn:sha1:e9867b818b75216427c7190f67354959dfb914db The original generic handler had an extra '%s' in the format string. Update tests that failed to catch this because the template to print status strings checked 'stat', which was not set. lib: fix return value for n_m_reindex 2020-07-20T11:54:42Z David Bremner david@tethera.net 2020-07-09T00:17:09Z urn:sha1:765ca7bc08f83a3c0f9ebffe58dab03634e45f37 Also update the documentation for the behaviour of n_m_get_thread_id that this fix relies on. lib: handle xapian exception in n_m_remove_all_tags 2020-07-20T11:54:42Z David Bremner david@tethera.net 2020-07-09T00:17:04Z urn:sha1:a2b90dc084c0224e56c1e63773048545788c7ad4 At least the exception we already catch should be reported properly. lib: add notmuch_message_has_maildir_flag_st 2020-07-20T11:54:42Z David Bremner david@tethera.net 2020-07-09T00:17:01Z urn:sha1:b7572ceb143773a988a4852ac3b7c85254009d0e Initially the new function is mainly tested indirectly via the wrapper. test: add regression test for notmuch_message_has_maildir_flag 2020-07-20T11:45:15Z David Bremner david@tethera.net 2020-07-09T00:17:00Z urn:sha1:b21f0fcb6abc4cf399c708c45e2e33a39a820a9e This passes the NULL return inside _ensure_maildir_flags does not break anything. Probably this should be handled more explicitely. lib: catch exceptions in n_m_get_flag, provide n_m_get_flag_st 2020-07-18T12:52:27Z David Bremner david@tethera.net 2020-07-04T15:18:05Z urn:sha1:2d04ed263121d970cd24a8c26ac924425a7ae3d2 It's not very nice to return FALSE for an error, so provide notmuch_message_get_flag_st as a migration path. Bump LIBNOTMUCH_MINOR_VERSION because the API is extended. lib: use COERCE_STATUS in n_m_{add,remove}_tag 2020-07-14T10:31:45Z David Bremner david@tethera.net 2020-07-05T13:00:26Z urn:sha1:78e9b3467d9f09228a444bb2eec93e4c765b7e9b Currently I don't know of a good way of testing this, but at least in principle a Xapian exception in _notmuch_message_{add,remove}_term would cause an abort in the library. lib: catch Xapian exceptions in n_m_remove_tag 2020-07-14T10:31:45Z David Bremner david@tethera.net 2020-07-05T13:00:25Z urn:sha1:aa8e3f4487897f0c650dc37d99153099c3d3df5e The churn here is again mainly re-indentation.