notmuch/lib/message.cc, branch 0.38.1_rc1 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.38.1_rc1 2023-07-22T10:11:46Z lib/message: check message type before deleting document 2023-07-22T10:11:46Z David Bremner david@tethera.net 2023-07-20T12:08:00Z urn:sha1:d93d49b6aed5b3f71651ffe79225da08c7d8f1aa It isn't really clear how this worked before. Traversing the terms of a document after deleting it from the database seems likely to be undefined behaviour at best lib/message-property: sync removed properties to the database 2023-03-30T11:01:09Z Kevin Boulain kevin@boula.in 2023-03-29T16:13:32Z urn:sha1:fb55ff28a2fdaa9c218af5ca10b1cae674869edd _notmuch_message_remove_all_properties wasn't syncing the message back to the database but was still invalidating the metadata, giving the impression the properties had actually been removed. Also move the metadata invalidation to _notmuch_message_remove_terms to be closer to what's done in _notmuch_message_modify_property and _notmuch_message_remove_term. lib: add better diagnostics for over long filenames. 2023-02-20T13:22:32Z David Bremner david@tethera.net 2022-12-27T17:08:47Z urn:sha1:09f2ad8e853375930c63bca847f623bc722b9cc0 Previously we just crashed with an internal error. With this change, the caller can handle it better. Update notmuch-new so that it doesn't crash with "unknown error code" because of this change. lib/message: move xapian call inside try/catch block in _n_m_delete 2022-12-27T15:59:46Z David Bremner david@tethera.net 2022-12-04T02:28:57Z urn:sha1:1d5d0ae68689e7b1d6b974e275f19371250c4b25 The call to delete_document can throw exceptions (and can happen in practice [1]), so catch the exception and extract the error message. As a side effect, also move the call to _n_m_has_term inside the try/catch. This should not change anything as that function already traps any Xapian exceptions. [1]: id:wwuk039sk2p.fsf@chaotikum.eu lib: check for writable db in n_m_tags_maildir_flags 2022-06-25T19:06:34Z David Bremner david@tethera.net 2022-05-25T10:51:17Z urn:sha1:6f749dd24a1c8138a05ac92884e8cb71098c7f6e The database needs to be writable because the list of stored file names will change in general. lib/message: check return status from _n_m_add_{path,folder}_terms 2022-06-25T15:55:02Z David Bremner david@tethera.net 2022-05-23T23:39:00Z urn:sha1:879ec9d76ad5caeb728c3f047d1da425d0b511eb Mainly to propagate information about Xapian exceptions. lib/message: check return status of _n_m_{add,remove}_term 2022-06-25T15:55:02Z David Bremner david@tethera.net 2022-05-23T23:38:59Z urn:sha1:b102d0ad11a3b4c605f6561fcfa93805b0e7d712 Xapian exceptions are not something that can be ignored, in general. lib/message: drop _notmuch_message_get_thread_id_only 2022-06-25T15:55:02Z David Bremner david@tethera.net 2022-05-23T23:38:57Z urn:sha1:bc80ff829ac205c68dfab45a21d4732cf5b8c2d0 This function has been unused since commit 4083fd8. lib/message: catch exceptions in _n_m_add_term 2022-06-25T15:55:02Z David Bremner david@tethera.net 2022-05-23T23:38:55Z urn:sha1:f48d2e2ff89a7e0a413b29ca844b2c785063eb3d Some code movement is needed to make sure the cache is only invalidated when the Xapian operation succeeds. lib/message: use false from stdbool.h 2022-05-26T11:30:00Z David Bremner david@tethera.net 2022-05-26T11:30:00Z urn:sha1:4f8a2d2253143d5dd3cee87d82bc48e1540d6a6d As far as I know, this is just a style / consistency thing, unless notmuch code starts defining FALSE inconsistently with false.