thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.5 2010-11-12T04:54:41Z 2010-11-12T04:54:41Z Carl Worth cworth@cworth.org 2010-11-12T04:54:41Z urn:sha1:7278383005de3a0d61ac3471162e7ef633d45076 This could have been a problematic bug. Fortuinately "gcc -O2" warns about it. 2010-11-12T04:53:21Z Carl Worth cworth@cworth.org 2010-11-12T04:53:21Z urn:sha1:fe8eeaf4a576b4cad2ec4faee8d5e373118771f8 The debian packaging is nice enough to notice when we accidentally leak private symbols to the public interface. 2010-11-12T00:36:02Z Carl Worth cworth@cworth.org 2010-11-12T00:36:02Z urn:sha1:96d99c383785dec67443ff1b45e2d2f8437398fa This is to prevent notmuch from destroying any information the user has encoded as flags in the maildir filename. Tests are also added to the test suite to verify the documented behavior. 2010-11-11T22:32:17Z Carl Worth cworth@cworth.org 2010-11-11T22:32:17Z urn:sha1:95dd5fe5d7e9cd8169a6e3174ea27376acd92870 Some people use notmuch with non-maildir files, (for example, email messages in MH format, or else cool things like using sluk[*] to suck down feeds into a format that notmuch can index). To better support uses like that, don't do any renaming for files that are not in a directory named either "new" or "cur". [*] https://github.com/krl/sluk/ 2010-11-11T11:50:42Z Carl Worth cworth@cworth.org 2010-11-11T11:50:42Z urn:sha1:37a8096fdc0584567aab43a8bede7b32860a3517 It is totally legitimate for a non-maildir directory to be named "new" (and not have a directory next to it named "cur"). To support this case at least, be silent about any rename failure. 2010-11-11T11:47:11Z Carl Worth cworth@cworth.org 2010-11-11T11:41:39Z urn:sha1:71a3201885d508f10ecd24a0887337e1624ffbf1 This function was documented as modifying every filename associated with the message. Fix it to actually do that. 2010-11-11T11:40:19Z Carl Worth cworth@cworth.org 2010-11-11T10:55:13Z urn:sha1:404db1de90f6e5a66c34077b38b18a39c955ece2 If a filename has no maildir info at all, (that is, it does not contain the sequence ":2,"), we consider this distinct from a filename with an empty maildir info, (the ":2," separator is present, but no flags characters follow). Specifically, we regard a missing info field as providing no information, so tags will remain unchanged. On the other hand, an info field that is present but has no flags set will cause various tags to be cleared, (or in the case of "unread", added). This fixes the "remove info" case of the maildir-sync tests in the test suite. 2010-11-11T11:40:19Z Carl Worth cworth@cworth.org 2010-11-11T08:26:04Z urn:sha1:81cbaafc0f64dcc77933d06e0d2b22ee38eefd88 We have tests to ensure that when the notmuch library renames a file that that rename takes place immediately in the database, (without requiring something like "notmuch new" to notice the change). This was working when the code was first added, but recently broke in the reworking of the maildir-synchronization interface since the tags_to_maildir_flags function can no longer assume that it is being called as part of _notmuch_message_sync. Fortunately, the fix is as simple as adding an explicit call to _notmuch_message_sync. 2010-11-11T11:40:19Z Carl Worth cworth@cworth.org 2010-11-11T08:18:35Z urn:sha1:4b6063397ffcc13f38757e7052e3dc6649d9703c As documented, this function now iterates over all filenames for the message, computing a logical OR of the flags set on the filenames, then uses the final result to set tags on the message. This change fixes 3 of the 10 maildir-sync tests that have been failing since being added. 2010-11-11T11:40:19Z Carl Worth cworth@cworth.org 2010-11-11T08:07:24Z urn:sha1:1d02dd64afe245a2b5a8461feeba975e61f0c233 This augments the existing notmuch_message_get_filename by allowing the caller access to all filenames in the case of multiple files for a single message. To support this, we split the iterator (notmuch_filenames_t) away from the list storage (notmuch_filename_list_t) where previously these were a single object (notmuch_filenames_t). Then, whenever the user asks for a file or filename, the message object lazily creates a complete notmuch_filename_list_t and then: For notmuch_message_get_filename, returns the first filename in the list. For notmuch_message_get_filenames, creates and returns a new iterator for the filename list.