thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=debian%2F0.20.2-1 2015-03-28T23:34:15Z 2015-03-28T23:34:15Z David Bremner david@tethera.net 2014-12-26T17:34:49Z urn:sha1:9d192da683b0656e37fc8d69c69698ca605926b3 You may wonder why _notmuch_message_file_open_ctx has two parameters. This is because we need sometime to use a ctx which is a notmuch_message_t. While we could get the database from this, there is no easy way in C to tell type we are getting. 2015-03-28T23:34:15Z David Bremner david@tethera.net 2014-12-26T16:25:35Z urn:sha1:736ac26407914425a9c94e86616225292cf716dd This is not supposed to change any functionality from an end user point of view. Note that it will eliminate some output to stderr. The query debugging output is left as is; it doesn't really fit with the current primitive logging model. The remaining "bad" fprintf will need an internal API change. 2015-03-28T23:34:15Z David Bremner david@tethera.net 2014-12-26T16:16:12Z urn:sha1:9b73a8bcc9cb381fc1a15013f4baa3ec9fdb97a7 This is needed by logging in functions outside message.cc that take only a notmuch_message_t object. 2015-01-02T16:18:42Z David Bremner david@tethera.net 2015-01-02T16:18:42Z urn:sha1:105537a809d1a385a3151de0c5b6235773782040 Apparently this is a supported and even idiomatic way of keeping a temporary object (e.g. like that returned from an operator dereference) alive. 2015-01-02T16:10:37Z David Bremner david@tethera.net 2014-12-28T10:45:08Z urn:sha1:3d978a0d61df072de7e4fd52120f3448cf8e9df6 Tamas Szakaly points out [1] that the bug fixed in 51b073c still exists in at least one place. This change follows the suggestion of [2] and creates a block scope temporary std::string to avoid the rules of iterators temporaries. [1]: id:20141226113755.GA64154@pamparam [2]: id:20141226230655.GA41992@pamparam 2014-10-25T17:26:54Z Austin Clements amdragon@mit.edu 2014-10-23T12:30:36Z urn:sha1:bc9c50602d20ce712188ea2cc3c5d30647d4d3f5 This updates the message abstraction to support ghost messages: it adds a message flag that distinguishes regular messages from ghost messages, and an internal function for initializing a newly created (blank) message as a ghost message. 2014-10-25T17:26:43Z Austin Clements aclements@csail.mit.edu 2014-10-24T12:49:15Z urn:sha1:d99491f27440d83f937131a861ca547bffb8bdf1 These macros help clarify basic bit-twiddling code and are written to be robust against C undefined behavior of shift operators. 2014-10-11T05:10:12Z Austin Clements amdragon@mit.edu 2014-10-06T23:17:09Z urn:sha1:7487e2e2214b27407e542df164a4d23520bbd8d8 In the interest of robustness, avoid undefined behavior of sortable_unserialise if the date value is missing. This shouldn't happen now, but ghost messages will have blank date values. 2014-10-11T05:09:54Z Austin Clements amdragon@mit.edu 2014-10-06T23:17:07Z urn:sha1:54ec8a0fd87ae7a32c8208be67a345c0eeea7f69 Previously, this was performed by notmuch_database_add_message. This happens to be the only caller currently (which is why this was safe), but we're about to introduce more callers, and it makes more sense to put responsibility for ID compression in the lower-level function rather than requiring each caller to handle it. 2014-09-24T18:19:34Z Jani Nikula jani@nikula.org 2014-09-22T09:54:52Z urn:sha1:f42e2e43a0284491c02a55e45c2cf4233b2b94f1 The function takes great care to preserve the first error status it encounters, yet fails to return that status to the caller. Fix it.