notmuch/lib/message.cc, branch debian/0.24.2-2

lib/message.cc: fix Coverity finding (use after free)

2017-03-18T23:59:46Z

The object where pointer to `data` was received was deleted before it was used in _notmuch_string_list_append(). Relevant Coverity messages follow: 3: extract Assigning: data = std::__cxx11::string(message->doc.()).c_str(), which extracts wrapped state from temporary of type std::__cxx11::string. 4: dtor_free The internal representation of temporary of type std::__cxx11::string is freed by its destructor. 5: use after free: Wrapper object use after free (WRAPPER_ESCAPE) Using internal representation of destroyed object local data.

lib/message.cc: use view number to invalidate cached metadata

2017-02-26T01:15:38Z

Currently the view number is incremented by notmuch_database_reopen

lib: handle DatabaseModifiedError in _n_message_ensure_metadata

2017-02-26T01:13:50Z

The retries are hardcoded to a small number, and error handling aborts than propagating errors from notmuch_database_reopen. These are both somewhat justified by the assumption that most things that can go wrong in Xapian::Database::reopen are rare and fatal. Here's the brief discussion with Xapian upstream: 24-02-2017 08:12:57 < bremner> any intuition about how likely Xapian::Database::reopen is to fail? I'm catching a DatabaseModifiedError somewhere where handling any further errors is tricky, and wondering about treating a failed reopen as as "the impossible happened, stopping" 24-02-2017 16:22:34 < olly> bremner: there should not be much scope for failure - stuff like out of memory or disk errors, which are probably a good enough excuse to stop

lib: make _notmuch_message_ensure_property_map static

2017-02-23T12:54:36Z

It's not called outside message.cc

lib: make _notmuch_message_ensure_metadata static

2017-02-23T12:54:25Z

It's not called anywhere outside message.cc.

lib: basic message-property API

2016-09-21T21:14:24Z

Initially, support get, set and removal of single key/value pair, as well as removing all properties.

lib: read "property" terms from messages.

2016-09-21T21:14:24Z

This is a first step towards providing an API to attach arbitrary (key,value) pairs to messages and retrieve all of the values for a given key.

Use https instead of http where possible

2016-06-05T11:32:17Z

Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.

lib: whitespace cleanup

2016-06-05T11:23:28Z

Cleaned the following whitespace in lib/* files: lib/index.cc: 1 line: trailing whitespace lib/database.cc 5 lines: 8 spaces at the beginning of line lib/notmuch-private.h: 4 lines: 8 spaces at the beginning of line lib/message.cc: 1 line: trailing whitespace lib/sha1.c: 1 line: empty lines at the end of file lib/query.cc: 2 lines: 8 spaces at the beginning of line lib/gen-version-script.sh: 1 line: trailing whitespace

complete ghost-on-removal-when-shared-thread-exists

2016-04-15T10:13:49Z

To fully complete the ghost-on-removal-when-shared-thread-exists proposal, we need to clear all ghost messages when the last active message is removed from a thread. Amended by db: Remove the last test of T530, as it no longer makes sense if we are garbage collecting ghost messages.