notmuch/lib/message.cc, branch debian/0.25_rc0-2

lib: wrap use of g_mime_utils_header_decode_date

2017-07-15T00:23:52Z

This changes return type in gmime 3.0

build: visibility=default for library structs is no longer needed

2017-05-13T11:38:18Z

Commit d5523ead90b6 ("Mark some structures in the library interface with visibility=default attribute.") fixed some mixed visibility issues with structs. With the symbol default visibility reversed, this is no longer a problem.

Replace index(3) with strchr(3)

2017-04-20T09:59:22Z

The index(3) function has been deprecated in POSIX since 2001 and removed in 2008, and most code in notmuch already calls strchr(3). This fixes a compilation error on Android whose libc does not have index(3).

lib: replace deprecated n_q_count_messages with status returning version

2017-03-22T11:35:07Z

This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name. One or two remaining uses of the (removed) non-status returning version fixed at the same time

Merge branch 'release'

2017-03-19T00:02:42Z

Merge in memory fixes

lib/message.cc: fix Coverity finding (use after free)

2017-03-18T23:59:46Z

The object where pointer to `data` was received was deleted before it was used in _notmuch_string_list_append(). Relevant Coverity messages follow: 3: extract Assigning: data = std::__cxx11::string(message->doc.()).c_str(), which extracts wrapped state from temporary of type std::__cxx11::string. 4: dtor_free The internal representation of temporary of type std::__cxx11::string is freed by its destructor. 5: use after free: Wrapper object use after free (WRAPPER_ESCAPE) Using internal representation of destroyed object local data.

lib: clamp return value of g_mime_utils_header_decode_date to >=0

2017-03-16T00:58:25Z

For reasons not completely understood at this time, gmime (as of 2.6.22) is returning a date before 1900 on bad date input. Since this confuses some other software, we clamp such dates to 0, i.e. 1970-01-01.

lib/message.cc: use view number to invalidate cached metadata

2017-02-26T01:15:38Z

Currently the view number is incremented by notmuch_database_reopen

lib: handle DatabaseModifiedError in _n_message_ensure_metadata

2017-02-26T01:13:50Z

The retries are hardcoded to a small number, and error handling aborts than propagating errors from notmuch_database_reopen. These are both somewhat justified by the assumption that most things that can go wrong in Xapian::Database::reopen are rare and fatal. Here's the brief discussion with Xapian upstream: 24-02-2017 08:12:57 < bremner> any intuition about how likely Xapian::Database::reopen is to fail? I'm catching a DatabaseModifiedError somewhere where handling any further errors is tricky, and wondering about treating a failed reopen as as "the impossible happened, stopping" 24-02-2017 16:22:34 < olly> bremner: there should not be much scope for failure - stuff like out of memory or disk errors, which are probably a good enough excuse to stop

lib: make _notmuch_message_ensure_property_map static

2017-02-23T12:54:36Z

It's not called outside message.cc