notmuch/lib/message.cc, branch debian/unstable

lib: move call to _n_m_invalidate_metadata

2026-01-14T22:18:24Z

It is wrong most of the time in _notmuch_message_remove_terms, but that function is too low level to know how to call _n_m_invalidate_metadata with the right argument, at least not without more extensive changes. This change merely makes the current behaviour more obvious, since the other calls cannot have relied on metadata being invalidated.

lib: return NOTMUCH_STATUS_OPERATION_INVALIDATED where appropriate

2025-08-09T10:12:23Z

The overall goal is to allow clients to restart operations in situations where that is the response recommended by the underlying Xapian library. Amended-by: db, added above explanation

lib: handle DatabaseModifiedError in _notmuch_message_create

2025-07-24T10:30:58Z

If an open database is modified sufficiently by other callers, the open instance becomes invalid and operations on it throw DatabaseModifiedError. Per Xapian documentation, the caller is then supposed to reopen the database and restart the query. This exception is currently not handled in _notmuch_message_create(), leading to the default handler abort()ing the process. Catch this exception in _notmuch_message_create() and return an error instead of crashing. Since the entire query becomes invalid - including results that have already been read by the caller - this situation cannot be handled by libnotmuch transparently. A new public function - notmuch_messages_status() - is added to allow the callers to check whether the messages iterator was exhausted or terminated early due to a runtime error. This also allows memory allocation failure to be signalled to the caller. Amended-By: David Bremner [replace use of notmuch_messages_valid]

lib/message: check message type before deleting document

2023-07-22T10:11:46Z

It isn't really clear how this worked before. Traversing the terms of a document after deleting it from the database seems likely to be undefined behaviour at best

lib/message-property: sync removed properties to the database

2023-03-30T11:01:09Z

_notmuch_message_remove_all_properties wasn't syncing the message back to the database but was still invalidating the metadata, giving the impression the properties had actually been removed. Also move the metadata invalidation to _notmuch_message_remove_terms to be closer to what's done in _notmuch_message_modify_property and _notmuch_message_remove_term.

lib: add better diagnostics for over long filenames.

2023-02-20T13:22:32Z

Previously we just crashed with an internal error. With this change, the caller can handle it better. Update notmuch-new so that it doesn't crash with "unknown error code" because of this change.

lib/message: move xapian call inside try/catch block in _n_m_delete

2022-12-27T15:59:46Z

The call to delete_document can throw exceptions (and can happen in practice [1]), so catch the exception and extract the error message. As a side effect, also move the call to _n_m_has_term inside the try/catch. This should not change anything as that function already traps any Xapian exceptions. [1]: id:wwuk039sk2p.fsf@chaotikum.eu

lib: check for writable db in n_m_tags_maildir_flags

2022-06-25T19:06:34Z

The database needs to be writable because the list of stored file names will change in general.

lib/message: check return status from _n_m_add_{path,folder}_terms

2022-06-25T15:55:02Z

Mainly to propagate information about Xapian exceptions.

lib/message: check return status of _n_m_{add,remove}_term

2022-06-25T15:55:02Z

Xapian exceptions are not something that can be ignored, in general.