notmuch/lib/messages.c, branch 0.40

lib: handle DatabaseModifiedError in _notmuch_message_create

2025-07-24T10:30:58Z

If an open database is modified sufficiently by other callers, the open instance becomes invalid and operations on it throw DatabaseModifiedError. Per Xapian documentation, the caller is then supposed to reopen the database and restart the query. This exception is currently not handled in _notmuch_message_create(), leading to the default handler abort()ing the process. Catch this exception in _notmuch_message_create() and return an error instead of crashing. Since the entire query becomes invalid - including results that have already been read by the caller - this situation cannot be handled by libnotmuch transparently. A new public function - notmuch_messages_status() - is added to allow the callers to check whether the messages iterator was exhausted or terminated early due to a runtime error. This also allows memory allocation failure to be signalled to the caller. Amended-By: David Bremner [replace use of notmuch_messages_valid]

lib: run uncrustify

2019-06-14T10:41:27Z

This is the result of running $ uncrustify --replace --config ../devel/uncrustify.cfg *.c *.h *.cc in the lib directory

fix misspelling

2019-06-11T10:24:31Z

Signed-off-by: Daniel Kahn Gillmor

lib/thread: change _resolve_thread_relationships to use depths

2018-09-06T11:07:13Z

We (finally) implement the XXX comment. It requires a bit of care not to reparent all of the possible toplevel messages. _notmuch_messages_has_next is not ready to be a public function yet, since it punts on the mset case. We know in the one case it is called, the notmuch_messages_t is just a regular list / iterator.

lib: add _notmuch_message_list_empty

2018-09-06T11:07:13Z

There is no public notmuch_message_list_t public interface, so to this is added to the private API. We use it immediately in thread.cc; future commits will use it further.

lib: convert notmuch_bool_t to stdbool internally

2017-10-10T01:27:16Z

C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the lib internally to stdbool.

Use https instead of http where possible

2016-06-05T11:32:17Z

Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.

lib: Eliminate _notmuch_message_list_append

2013-02-19T00:20:38Z

This API invited micro-optimized and complicated list pointer manipulation and is no longer used.

lib: fix messages.c build warn

2012-01-10T10:33:23Z

lib/messages.c: In function ‘notmuch_messages_move_to_next’: lib/messages.c:131:2: warning: ISO C forbids ‘return’ with expression, in function returning void [-pedantic] Signed-off-by: Jani Nikula

Implement an internal generic string list and use it.

2011-03-21T06:45:18Z

This replaces the guts of the filename list and tag list, making those interfaces simple iterators over the generic string list. The directory, message filename, and tags-related code now build generic string lists and then wraps them in specific iterators. The real wins come in later patches, when we use these for even more generic functionality. As a nice side-effect, this also eliminates the annoying dependency on GList in the tag list.