notmuch/lib/notmuch-private.h, branch 0.16

lib: add --exclude=all option

2013-05-14T00:32:03Z

Adds a exclude all option to the lib which means that excluded messages are completely ignored (as if they had actually been deleted).

lib: Eliminate _notmuch_message_list_append

2013-02-19T00:20:38Z

This API invited micro-optimized and complicated list pointer manipulation and is no longer used.

lib: Separate list of all messages from top-level messages

2013-02-19T00:20:24Z

Previously, thread.cc built up a list of all messages, then proceeded to tear it apart to transform it into a list of top-level messages. Now we simply build a new list of top-level messages. This simplifies the interface to _notmuch_message_add_reply, eliminates the pointer acrobatics from _resolve_thread_relationships, and will enable us to do things with the list of all messages in the following patches.

Fix the COERCE_STATUS macro

2012-09-27T15:51:51Z

Fix the COERCE_STATUS macro to handle _internal_error being declared as void function. Note that the function _internal_error does not return. Evaluating to NOTMUCH_STATUS_SUCCESS is done purely to appease the compiler. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

lib: Make notmuch_database_get_directory return NULL if the directory is not found

2012-05-24T01:30:55Z

Using the new support from _notmuch_directory_create, this makes notmuch_database_get_directory a read-only operation that simply returns the directory object if it exists or NULL otherwise. This also means that notmuch_database_get_directory can work on read-only databases. This change breaks the directory mtime workaround in notmuch-new.c by fixing the exact issue it was working around. This permits mtime update races to prevent scans of changed directories, which non-deterministically breaks a few tests. The next patch fixes this.

lib: Perform the same transformation to _notmuch_database_filename_to_direntry

2012-05-24T01:30:43Z

Now _notmuch_database_filename_to_direntry takes a flags argument and can indicate if the necessary directory documents do not exist. Again, callers have been updated, but retain their original behavior.

lib: Perform the same transformation to _notmuch_database_find_directory_id

2012-05-24T01:30:32Z

Now _notmuch_database_find_directory_id takes a flags argument, which it passes through to _notmuch_directory_create and can indicate if the directory does not exist. Again, callers have been updated, but retain their original behavior.

lib: Make directory document creation optional for _notmuch_directory_create

2012-05-24T01:30:20Z

Previously this function would create directory documents if they didn't exist. As a result, it could only be used on writable databases. This adds an argument to make creation optional and to make this function work on read-only databases. We use a flag argument to avoid a bare boolean and to permit future expansion. Both callers have been updated, but currently retain the old behavior. We'll take advantage of the new argument in the following patches.

lib: work around talloc_steal usage from C++ code

2012-04-15T12:42:15Z

Implicit typecast from 'void *' to 'T *' is okay in C, but not in C++. In talloc_steal, an explicit cast is provided for type safety in some GCC versions. Otherwise, a cast is required. Provide a template function for this to maintain type safety, and redefine talloc_steal to use it. The template must be outside the extern "C" block (NOTMUCH_BEGIN_DECLS and NOTMUCH_END_DECLS), but keep it within the GCC visibility #pragma. No functional changes, apart from making the library build with compilers other than recent GCC. Signed-off-by: Jani Nikula

lib: Add the exclude flag to notmuch_query_search_threads

2012-03-02T12:28:39Z

Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to notmuch_query_search_threads. Implemented by inspecting the tags directly in _notmuch_thread_create/_thread_add_message rather than as a Xapian query for speed reasons. Note notmuch_thread_get_matched_messages now returns the number of non-excluded matching messages. This API is not totally desirable but fixing it means breaking binary compatibility so we delay that.