notmuch/lib/notmuch-private.h, branch debian/unstable

lib: return NOTMUCH_STATUS_OPERATION_INVALIDATED where appropriate

2025-08-09T10:12:23Z

The overall goal is to allow clients to restart operations in situations where that is the response recommended by the underlying Xapian library. Amended-by: db, added above explanation

lib: add notmuch_threads_status()

2025-08-04T13:43:35Z

While a number of errors can happen when iterating over threads (DatabaseModifiedError, memory allocation errors, etc.), the API currently cannot signal them to the caller, and either triggers an internal error (aborting the caller) or returns NULL from notmuch_threads_get() with no information on what actually went wrong. Add a new public function notmuch_threads_status() - similar to previously added notmuch_messages_status() - that allows propagating those errors to the caller. Use this to remove the INTERNAL_ERROR() in _notmuch_thread_create() (triggered by T642). Fixes: https://github.com/pazz/alot/issues/1460 Amended-By: db. Resolved whitespace disagreement between emacs and uncrustify in favour of uncrustify.

lib: handle DatabaseModifiedError in _notmuch_message_create

2025-07-24T10:30:58Z

If an open database is modified sufficiently by other callers, the open instance becomes invalid and operations on it throw DatabaseModifiedError. Per Xapian documentation, the caller is then supposed to reopen the database and restart the query. This exception is currently not handled in _notmuch_message_create(), leading to the default handler abort()ing the process. Catch this exception in _notmuch_message_create() and return an error instead of crashing. Since the entire query becomes invalid - including results that have already been read by the caller - this situation cannot be handled by libnotmuch transparently. A new public function - notmuch_messages_status() - is added to allow the callers to check whether the messages iterator was exhausted or terminated early due to a runtime error. This also allows memory allocation failure to be signalled to the caller. Amended-By: David Bremner [replace use of notmuch_messages_valid]

Pass error message from GLib ini parser to CLI

2023-09-23T11:34:48Z

The function _notmuch_config_load_from_file is only called in two places in open.cc. Update internal API to match the idiom in open.cc. Adding a newline is needed for consistency with other status strings. Based in part on a patch [1] from Eric Blake. [1]: id:20230906153402.101471-1-eblake@redhat.com

lib: index attachments with mime types matching index.as_text

2023-04-02T22:24:43Z

Instead of skipping indexing all attachments, we check of a (user configured) mime type that is indexable as text.

lib: add NOTMUCH_STATUS_CLOSED_DATABASE, use in _n_d_ensure_writable

2022-06-25T19:06:18Z

In order for a database to actually be writeable, it must be the case that it is open, not just the correct type of Xapian object. By explicitely checking, we are able to provide better error reporting, in particular for the previously broken test in T566-lib-message.

lib: Add missing private status values.

2022-06-25T19:06:10Z

These were missed when the corresponding status codes were added.

lib: define macro NODISCARD

2022-06-25T15:55:02Z

In either C++17 (or later) mode, or when running cppcheck, this can be used to selectively generate warnings about discarded return values.

lib/message: drop _notmuch_message_get_thread_id_only

2022-06-25T15:55:02Z

This function has been unused since commit 4083fd8.

lib: make indexopts pointers opaque

2021-10-23T12:48:39Z

There is no reason for anything outside the indexopts.c compilation unit to have access to structure members.