notmuch/lib/open.cc, branch 0.32_rc1

compat: rename {,notmuch_}canonicalize_file_name

2021-04-24T11:07:00Z

When compat canonicalize_file_name was introduced, it was limited to C code only because it was used by C code only during that time. >From 5ec6fd4d, (lib/open: check for split configuration when creating database., 2021-02-16), lib/open.cc, which is C++, relies on the existent of canonicalize_file_name. However, we can't blindly enable canonicalize_file_name for C++ code, because different implementation has different additional signature for C++ and users can arbitrarily add -DHAVE_CANONICALIZE_FILE_NAME=0 to {C,CXX}FLAGS. Let's move our implementation into a util library. Helped-by: Tomi Ollila Signed-off-by: Đoàn Trần Công Danh

lib: provide notmuch_config_path

2021-03-27T12:26:14Z

Since the library searches in several locations for a config file, the caller does not know which of these is chosen in the usual case of passing NULL as a config file. This changes provides an API for the caller to retrieve the name of the config file chosen. It will be tested in a following commit.

CLI+lib: detect missing database in split configurations.

2021-03-27T12:26:14Z

Eventually we want to do all opening of databases in the top level (main function). This means that detection of missing databases needs to move out of subcommands. It also requires updating the library to use the new NO_DATABASE status code.

lib/open: canonicalize relative path read from config file

2021-03-27T12:26:14Z

This matches functionality in the the CLI function notmuch_config_get_database_path, which was previously used in the CLI code for all calls to open a database.

lib: provide notmuch_database_load_config

2021-03-27T12:26:14Z

This is mainly targetted at notmuch-config.c, or similar applications that don't necessarily need both a configuration file and a database to exist.

lib/open: pull _load_key_file out of _choose_database_path

2021-03-27T12:26:14Z

Although this increases code duplication, it also increases flexibility in handling various combinations of missing config file and missing database.

lib/open: fix leaks calling _trial_open

2021-03-27T12:12:28Z

_trial_open can't know if the PATH_ERROR return value will cause the error message to be returned from the library, so it's up the caller to clean up if not.

lib/config: add configuration variable for backup directory

2021-03-20T10:51:36Z

Like the hook directory, we primarily need a way to communicate this directory between various components, but we may as well let the user configure it. Most of the diff is generalizing choose_hook_dir to work for both backup and hook directories.

lib/open: fix hook directory calculation in split configuration

2021-03-20T10:50:13Z

Choose sibling directory of xapian database, as .notmuch may not exist. libgen.h is already used in debugger.c, so it is not a new dependency / potential portability problem.

lib/compact: enable split config

2021-03-20T10:50:06Z

This promotes _choose_xapian_path from static to extern linkage in order to share between open.cc and database.cc.