notmuch/lib/open.cc, branch 0.33

Merge tag 'debian/0.32.3-1'

2021-08-19T04:46:42Z

notmuch release 0.32.3-1 for unstable (sid) [dgit] [dgit distro=debian no-split --quilt=linear]

lib/open: look in MAILDIR for database, as documented.

2021-08-18T00:09:21Z

This fixes the bug id:87bl9lx864.fsf@kisara.moe

lib: autocommit after some number of completed transactions

2021-06-27T17:03:00Z

This change addresses two known issues with large sets of changes to the database. The first is that as reported by Steven Allen [1], notmuch commits are not "flushed" when they complete, which means that if there is an open transaction when the database closes (or e.g. the program crashes) then all changes since the last commit will be discarded (nothing is irrecoverably lost for "notmuch new", as the indexing process just restarts next time it is run). This does not really "fix" the issue reported in [1]; that seems rather difficult given how transactions work in Xapian. On the other hand, with the default settings, this should mean one only loses less than a minutes worth of work. The second issue is the occasionally reported "storm" of disk writes when notmuch finishes. I don't yet have a test for this, but I think committing as we go should reduce the amount of work when finalizing the database. [1]: id:20151025210215.GA3754@stebalien.com

lib/{open,message}: make some internal functions static

2021-06-05T18:40:00Z

They are not used outside their file, so being extern seems like an oversight

Merge branch 'release'

2021-05-15T12:10:58Z

lib/open: restore default database path of $HOME/mail

2021-05-15T11:40:05Z

Although this default worked for "notmuch config get", it didn't work most other places. Restore the previous functionality, with the wrinkle that XDG locations will shadow $HOME/mail if they exist. This fixes a bug reported by Jack Kamm in id:87eeefdc8b.fsf@gmail.com

lib: make glib initialization thread-safe

2021-05-14T01:21:57Z

In principle this could be done without depending on C++11 features, but these features should be available since gcc 4.8.1, and this localized usage is easy to replace if it turns out to be problematic for portability.

lib/notmuch_database_reopen: reload some database metadata

2021-05-12T11:40:04Z

In some uses of reopen, new documents and threads maybe have been added, and e.g. compaction may have changed the uuid.

compat: rename {,notmuch_}canonicalize_file_name

2021-04-24T11:07:00Z

When compat canonicalize_file_name was introduced, it was limited to C code only because it was used by C code only during that time. >From 5ec6fd4d, (lib/open: check for split configuration when creating database., 2021-02-16), lib/open.cc, which is C++, relies on the existent of canonicalize_file_name. However, we can't blindly enable canonicalize_file_name for C++ code, because different implementation has different additional signature for C++ and users can arbitrarily add -DHAVE_CANONICALIZE_FILE_NAME=0 to {C,CXX}FLAGS. Let's move our implementation into a util library. Helped-by: Tomi Ollila Signed-off-by: Đoàn Trần Công Danh

lib: provide notmuch_config_path

2021-03-27T12:26:14Z

Since the library searches in several locations for a config file, the caller does not know which of these is chosen in the usual case of passing NULL as a config file. This changes provides an API for the caller to retrieve the name of the config file chosen. It will be tested in a following commit.