notmuch/lib/open.cc, branch 0.37thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.372022-01-15T19:53:31Zlib/open: use notmuch->params to track split status2022-01-15T19:53:31ZDavid Bremnerdavid@tethera.net2021-12-25T13:33:03Zurn:sha1:63b4c469835133ac44b7db516fc54b8a4abb90a8
Persisting this status will allow us to use the information in other
compilation units, in particular when setting configuration defaults.
lib/open: use db struct as talloc ctx for choose_database_path2022-01-15T19:51:33ZDavid Bremnerdavid@tethera.net2021-12-25T13:33:02Zurn:sha1:fd0edeb561e5593d8a834fcc74602b2d8c637123
The extra talloc struct "local" was left over from before the notmuch
struct was allocated earlier. Having the notmuch struct available in
this function will allow more flexibility to track the configuration
variations (e.g. split vs. non-split).
Merge branch 'release'2021-12-29T18:20:49ZDavid Bremnerdavid@tethera.net2021-12-29T18:20:49Zurn:sha1:3eb25c94bd8fe4065d6df6d665ee393cb9a0ad6flib/open: do not consider .notmuch alone as an existing database.2021-12-29T18:11:21ZDavid Bremnerdavid@tethera.net2021-12-25T21:22:56Zurn:sha1:25e0f5e59293ce961549201fdc74f81a3cc1675c
It makes perfect sense for users to want to pre-create .notmuch,
e.g. to install hooks, so we should handle the case of a .notmuch
directory without an actual xapian database more gracefully.
lib/config: use g_key_file_get_string to read config values2021-12-04T16:17:09ZDavid Bremnerdavid@tethera.net2021-09-30T18:59:54Zurn:sha1:18cdd21b8b2ef056062700607eade43909c32cd2
Unlike the previous g_key_file_get_value, this version processes
escape codes for whitespace and \. The remaining two broken tests from
the last commit are because "notmuch config get" treats every value as
a list, and thus the previously introduces stripping of leading
whitespace applies.
Merge branch 'release'2021-12-04T13:27:30ZDavid Bremnerdavid@tethera.net2021-12-04T13:27:30Zurn:sha1:1e7d33961e626488b09b56c8543e8edf00648670lib/open: track which parameters are passed2021-12-04T00:50:03ZDavid Bremnerdavid@tethera.net2021-10-28T01:34:18Zurn:sha1:d467444085d96229172ce29ef8654c3c459b6ce2
This will be used to fine tune the loading of configuration for
certain special configuration items (initially just "database.path").
lib/open: replace call to deprecated notmuch_database_open_verbose2021-10-30T18:04:28ZDavid Bremnerdavid@tethera.net2021-10-23T12:27:02Zurn:sha1:efbf5bafaf15cc99e272bd75e71688c96130d9d5
Essentially inline the existing shim definition of
notmuch_database_open_verbose.
lib/load_config: deallocate / NULL database on fatal error2021-10-30T16:51:50ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:38Zurn:sha1:fe51c275fcd7107d92b40de511086300ba4060ed
This fixes a potential memory leak, and makes the behaviour of
notmuch_database_load_config (somewhat) consistent with
n_d_{open,create} with config.
lib/create: fix memory leak, ensure *database=NULL on error2021-10-30T16:47:47ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:36Zurn:sha1:2ba50b52302dce08068843e0029f9ee935a0d7f3
This code previously relied on _finish_open to free the notmuch struct
on errors (except for the case of database == NULL, which was a
potential double free). When we removed those frees from _finish_open,
we introduced a (small) memory leak.
In this commit, fix the memory leak, and harmonize the on-error
behaviour with n_d_open_with_config.